-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix grammar, unnecessary escape in closed circle description #338
Conversation
If the purpose of this change is unclear: The current, escaped, "who\'s in it" appears with the escape in the UI. To fix this, either the escape should be corrected, or an apostrophe should be avoided. It's possible to word the string more clearly without the apostrophe anyway. |
Hi @hoxia Unfortunately I'll have to close the PR. The translations in the l10n folder are fully handled via transifex, so they would need to be fixed at https://app.transifex.com/nextcloud/nextcloud/translate/#en_GB/circles/485650950 |
Change incorrect use of "it's", and remove unnecessary escaped apostrophe by changing "who\'s in it" to "its membership".
Note that this change likely needs bulk edits (find-and-replace) across localization files. Only en_GB was edited to demonstrate the likely needed change.