fix: Remove fully_qualified_strict_types again #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Broke the update in notifications, works after bumping cs-fixer as well: |
come-nc
previously approved these changes
Feb 1, 2024
come-nc
reviewed
Feb 1, 2024
nickvergessen
force-pushed
the
nickvergessen-patch-1
branch
from
410e3c1
to
d0432bf
Compare
nickvergessen
requested review from
come-nc,
ChristophWurst and
provokateurin
ChristophWurst
previously approved these changes
Feb 1, 2024
There are currently too many issues for the rule on the project itself #17 PHP-CS-Fixer/PHP-CS-Fixer#7719 Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
nickvergessen-patch-1
branch
from
464fe06
to
35fd40e
Compare
|
As per #17 we remove the rule for now again instead |
nickvergessen
changed the title
come-nc
approved these changes
Feb 1, 2024
|
We may still want to update php-cs-fixer? |
It's not required anymore, so I prefer to not break things :-X |
ChristophWurst
approved these changes
Feb 1, 2024
Yeah but then you’re not fixing things either |
No need to fix something that is not broken. We can make a new version/branch with 2.0 requiring 8.0 and cs-fixer 3.48+ or something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fully_qualified_strict_types=>leading_backslash_in_global_namespacewe want to use was only introduced with 3.46 PHP-CS-Fixer/PHP-CS-Fixer@0061223