Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share link users cannot close "Recent pages" #1192

Closed
chmac opened this issue Apr 9, 2024 · 1 comment · Fixed by #1320
Closed

Share link users cannot close "Recent pages" #1192

chmac opened this issue Apr 9, 2024 · 1 comment · Fixed by #1320
Assignees
Labels
2. developing bug Something isn't working

Comments

@chmac
Copy link

chmac commented Apr 9, 2024

Describe the bug
According to #835 I understood that the "Recent pages" should be closable and this would be remembered per user. But in our "share link" view, when the link has read only view to the page, we are unable to close it at all.

To Reproduce
Steps to reproduce the behavior:

  1. Create a collective
  2. Create a share link
  3. Open share link in a private tab
  4. Notice that clicking "Recent pages" does not fold the section

Expected behavior
I expected that the share link would be able to close the section, and ideally, that it would remain closed for future users of the same link.

Screenshots

Screenshot 2024-04-09 at 08 20 17

I think the Recent pages is actually greyed out here.

Server details:

  • Collectives app version: 2.10.1
  • Nextcloud version: 28.0.4
  • PHP Version: Version: 8.2.17
  • Database: Type: mysql Version: 10.5.24

Client details:

  • OS: macOS
  • Browser: Chrome, Safari
@chmac chmac added the bug Something isn't working label Apr 9, 2024
@estux
Copy link

estux commented Jun 11, 2024

I'm experiencing the same bug.
Navigating a publicly shared Collective (with Only Read permission) I cannot fold the Recent Pages section on top of the Landing Page.
The little arrow seems not "clickable" on mobile.
I'm using Fennec / Firefox android 125.3.0 and Collectives 2.11 (Nextcloud 28.0.6)
Thank you

@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Jun 12, 2024
@mejo- mejo- self-assigned this Jun 12, 2024
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Jun 12, 2024
mejo- added a commit that referenced this issue Jun 12, 2024
Fixes: #1192

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- moved this from 📄 To do (~10 entries) to 🏗️ In progress in 📝 Office team Jun 19, 2024
@mejo- mejo- closed this as completed in e99d6fd Jun 26, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📝 Office team Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants