-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After editing a page and returning to "view" mode, the view is not updated #1194
Comments
Additional things I discovered: In some cases even reloading a page may still stick to the old version first and then load the new version after a delay of 1-2 seconds. Something happened with one of the latest updates. I also noticed, that the "Last changed by" header is not correct: it is missing the name of the person who changed the page and the date is also wrong - this is for example a document which I just edited a few minutes ago: |
@arnowelzel I've had this issue for a long time, I think it's a long standing bug (never bothered to write a bug report, so thank you). |
Unfortunately I don't have time nor the experience with Vue.js to work on this problem. But if financial sponsoring helps, I am willing to do this. If this issue can not be addressed soon I have to stop using Collectives since my users get really confused when they see the old file version all the time. |
Dear @arnowelzel, I hope to find time to look into this the following days. |
This is expected behaviour. When you type something in the editor, it first only gets saved to the editing session. These changes get written to the markdown file automatically every 30 seconds, or when you close the editor. When you just reload the page, this cannot be detected and the no autosave is happening. Then Collectives loads the markdown file in view mode first, but as soon as the editor with the editing session is restored, the updated content from this session is loaded into the view mode as well. What is unexpected though is that editing the document in edit mode doesn't result in the content in view mode being updated. In other words, when you switch to view mode, you should always still see latest content from the editing session. The console errors you see indeed look related. It might be a bug in the Text app though. Will further investigate. |
As a workaround, manually saving the document should always help. You can do so by clicking on the checkmark button in edit mode that has a blue indicator dot while changes in the editing session are unsaved in the markdown file |
My current workaround was to configure the Collectives to start in edit mode by default and hiding the "Done"/"Edit" buttons using Custom CSS. Explaining the users to always click the checkmark first, before they click "Done" is too complicated. If this behaviour can be reproduced somehow and there is fix for this issue I can revert this quite easy and at the moment I don't need "view only" users. Thanks for your support! |
JFTR: the last update seems to work fine here so far. |
Describe the bug
When I edit a Collective page and finish the edit, it can happen, that the "view" mode is not updated and the document view reverts to the state before, eventhough the file was properly updated.
To Reproduce
It is not easy to reproduce - it just happens sometimes. But I'm pretty sure, that this started with Collectives 2.10.1 and Nextcloud 28.0.4 and still happens with Nextcloud 29.0.0.
When it happens, there are runtime errors in the JavaScript console about
Debounce method called with different contexts
invue.runtime.esm.js:3065
and the same error also inEditor.vue:702
Expected behavior
After editing a document and switching back to "view" mode, the changes are still visible.
Screenshots
Server details:
Client details:
Logs
Nextcloud log (data/nextcloud.log)
Browser log
The text was updated successfully, but these errors were encountered: