-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Team button that redirects to contacts app #1168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, that was fast 😊
Overall looks good, but I have some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be in the action menu and not visible by default, and it should say "Team page"
To be honest I think that "Team page" is a bit ambiguous, given that "page" is a term used a lot in the collectives app for the pages of a collective. And from earlier discussions I remembered that we decided to have this button somehow visible and not hidden in an action menu, no? Maybe we can add it to both places? |
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
5eaecbb
to
d17a27e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
📝 Summary
adds a button to redirect to the team corresponding to the collective
🖼️ Screenshots
🚧 TODO
write cypress tests
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)