Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Team button that redirects to contacts app #1168

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Conversation

grnd-alt
Copy link
Member

📝 Summary

adds a button to redirect to the team corresponding to the collective

🖼️ Screenshots

image

🏚️ Before 🏡 After
no button button

🚧 TODO

write cypress tests

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@grnd-alt grnd-alt linked an issue Mar 20, 2024 that may be closed by this pull request
2 tasks
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, that was fast 😊

Overall looks good, but I have some comments.

src/components/Page/LandingPageWidgets/MembersWidget.vue Outdated Show resolved Hide resolved
src/components/Page/LandingPageWidgets.vue Outdated Show resolved Hide resolved
src/components/Page/LandingPageWidgets.vue Outdated Show resolved Hide resolved
Copy link

cypress bot commented Mar 20, 2024

6 failed and 5 flaky tests on run #1478 ↗︎

6 203 0 0 Flakiness 5

Details:

add Team button that redirects to contacts app
Project: Collectives Commit: d17a27e67b
Status: Failed Duration: 13:31 💡
Started: Mar 25, 2024 9:00 PM Ended: Mar 25, 2024 9:13 PM
Failed  pages-links.spec.js • 3 failed tests • Nextcloud stable27

View Output

Test Artifacts
Page link handling > Link handling to viewer in edit mode > Opens link with relative path to pdf in Nextcloud in viewer Screenshots
Page link handling > Link handling public share > Public share in edit mode: opens link with absolute path to page in this collective in same tab Screenshots
Page link handling > Link handling public share > Public share in edit mode: opens link to external website in new tab Screenshots
Failed  collective-share.spec.js • 1 failed test • Nextcloud stable27

View Output

Test Artifacts
Collective Share > collective share > Allows opening and editing a shared (editable) collective Screenshots
Failed  pages-links.spec.js • 2 failed tests • Nextcloud master

View Output

Test Artifacts
Page link handling > Link handling to viewer in view mode > Opens link with absolute path to image in Nextcloud in viewer Screenshots
Page link handling > Link handling to viewer in view mode > Opens link with relative path to pdf in Nextcloud in viewer Screenshots
Flakiness  page-list.spec.js • 1 flaky test • Nextcloud stable27

View Output

Test Artifacts
Page list > Page trash > allows to trash and restore page with subpage and attachment Screenshots
Flakiness  pages-links.spec.js • 4 flaky tests • Nextcloud master

View Output

Test Artifacts
Page link handling > Link handling to viewer in view mode > Opens link with absolute path to text file in Nextcloud in viewer Screenshots
Page link handling > Link handling to collectives in view mode > Opens link with relative path to page in this collective with fileId in same tab Screenshots
Page link handling > Link handling to collectives in view mode > Opens link with relative path to page in this collective with fileId and outdated path in same tab Screenshots
Page link handling > Link handling to collectives in view mode > Opens link with relative path to page in this collective without fileId in same tab Screenshots

Review all test suite changes for PR #1168 ↗︎

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be in the action menu and not visible by default, and it should say "Team page"

@mejo-
Copy link
Member

mejo- commented Mar 20, 2024

I think this should be in the action menu and not visible by default, and it should say "Team page"

To be honest I think that "Team page" is a bit ambiguous, given that "page" is a term used a lot in the collectives app for the pages of a collective. And from earlier discussions I remembered that we decided to have this button somehow visible and not hidden in an action menu, no? Maybe we can add it to both places?

Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
@grnd-alt grnd-alt force-pushed the feat/1121-overview-page branch from 5eaecbb to d17a27e Compare March 25, 2024 18:25
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@mejo- mejo- merged commit bc2cedb into main Mar 26, 2024
44 of 49 checks passed
@mejo- mejo- deleted the feat/1121-overview-page branch March 26, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overview page
4 participants