feat(PageReference): Public page reference lookups #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 failed and 2 flaky tests on run #1734 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Pages > Creating a page from template > New page has template content |
Screenshots
|
|
pages-links.spec.js • 1 flaky test • Nextcloud master
| Test | Artifacts | |
|---|---|---|
| Page link handling > Link handling to collectives in view mode > Opens link with relative path to page in this collective without fileId in same tab |
Screenshots
|
|
pages.spec.js • 1 flaky test • Nextcloud master
| Test | Artifacts | |
|---|---|---|
| Pages > Editing a page > Lists attachments for the page and allows restore |
Screenshots
|
|
Review all test suite changes for PR #1369 ↗︎
mejo-
force-pushed
the
feat/public_page_references
branch
2 times, most recently
from
484cf64 to
cb0bb54
Compare
mejo-
force-pushed
the
feat/public_page_references
branch
from
cb0bb54 to
cd09e28
Compare
max-nextcloud
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Nice to see the tests added - that makes me confident it works.
Only skimmed through the php code though. So if you want a thorough review you'll need to wait for @juliushaertl or so.
Besides one minor suggestion this looks good to me.
mejo-
force-pushed
the
feat/public_page_references
branch
from
cd09e28 to
30b9cd3
Compare
Allow to resolve page references by share token to support lookups from public shares. This adds link previews for links to other pages in the same collective in public shares. It requires the new public reference API from nextcloud/server#46378 and the Text app being built with nextcloud-libraries/nextcloud-vue#5800. Fixes: #1275 Contributes to nextcloud/text#5520 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
feat/public_page_references
branch
from
30b9cd3 to
ad14083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to resolve page references by share token to support lookups from public shares. This adds link previews for links to other pages in the same collective in public shares.
It requires the new public reference API from nextcloud/server#46378 and the Text app being built with nextcloud-libraries/nextcloud-vue#5800.
Fixes: #1275
Contributes to nextcloud/text#5520
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)