Skip to content

Bump psalm error level and fix issues spotted by psalm#1768

Merged
mejo- merged 26 commits intomainfrom
feat/psalm_deprectations_error
May 26, 2025
Merged

Bump psalm error level and fix issues spotted by psalm#1768
mejo- merged 26 commits intomainfrom
feat/psalm_deprectations_error

Conversation

@mejo-
Copy link
Member

@mejo- mejo- commented May 20, 2025 •
edited
Loading

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

@mejo- mejo- self-assigned this May 20, 2025
@mejo- mejo- requested a review from max-nextcloud as a code owner May 20, 2025 15:55
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team May 20, 2025
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team May 20, 2025
@mejo- mejo- requested a review from a team May 20, 2025 15:56
@mejo- mejo- force-pushed the feat/psalm_deprectations_error branch from 2e15d6d to 3f0c810 Compare May 20, 2025 15:59
max-nextcloud
max-nextcloud reviewed May 22, 2025
View reviewed changes
mejo- added 15 commits May 26, 2025 10:58
@mejo-
chore(psalm): Migrate spaces to tabs
3b7eac3 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
test(psalm): Bump error level to 4
7f0f056 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(PageInfo): Allow null fullWidth
deed7a9 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(CollectiveStorage): Fix return type and add missing import
45d6559 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(ExpireManager): Remove dead logic
17b30e9 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(ExpireManager): Do not expire labeled versions
a526189 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(ExpireManager): Add missing return types
de924e2 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(ExpireManager): Remove accidentally removed condition
5111991 
The condition was added in bfae0d1, but seems like by accident.

Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(VersionsBackend): Fix type for CollectiveVersion argument
e66c649 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(CollectiveShare): Adjust return types and remove dead code
eaed2db 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(psalm): Update stubs for circles app
c4cac94 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
chore(psalm): Migrate spaces to tabs
2bb4897 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(MountProvider): Remove nulls from returned array in getMountsForUser
1142ed6 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix: Don't call getUID() on null
d5582f8 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(PageController): always pass index to copy/move function
a9d01d5 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the feat/psalm_deprectations_error branch from 3f0c810 to d94658c Compare May 26, 2025 13:41
@mejo- mejo- changed the title feat(psalm): Treat deprecated code as error Bump psalm error level and fix issues spotted by psalm May 26, 2025
@mejo- mejo- force-pushed the feat/psalm_deprectations_error branch from d94658c to 32ca079 Compare May 26, 2025 13:46
mejo- added 3 commits May 26, 2025 15:54
@mejo-
fix(CollectiveUserSettings): Fix return types
1a6d283 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(DB): Replace deprecated QueryBuilder->execute() with `executeQu…
cfdcf7b 
…ery()`

Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(FileIndexer): Make psalm happy by using a local variable for index
d8189c0 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the feat/psalm_deprectations_error branch 2 times, most recently from 1b7a20d to 534032a Compare May 26, 2025 13:55
@mejo-
fix(DB): Fix return codes
1703911 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the feat/psalm_deprectations_error branch from 534032a to 1703911 Compare May 26, 2025 14:02
mejo- added 7 commits May 26, 2025 16:04
@mejo-
fix(Listeners): Handle empty userId
b44d400 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(PageInfo): Always pass int to setSize
3826a17 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(Migration): Fix return type
938c4d6 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(CollectiveFolderManager): Several typing fixes
737c39a 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(CollectiveFolderManager): Ignore inShare from cli
3d9bf05 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(CircleHelper): Make psalm ignore false positives
913b2d2 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(TemplateService): Fix typing for parentId
b27da7e 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- requested a review from max-nextcloud May 26, 2025 15:05
@mejo- mejo- merged commit 86322be into main May 26, 2025
54 of 55 checks passed
@mejo- mejo- deleted the feat/psalm_deprectations_error branch May 26, 2025 16:30
@github-project-automation github-project-automation bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grnd-alt grnd-alt grnd-alt approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

Assignees

@mejo- mejo-

Labels

3. to review tests

Projects

📝 Productivity team
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mejo- @grnd-alt @max-nextcloud