Conversation
mejo-
force-pushed
the
feat/playwright
branch
9 times, most recently
from
6e65c15 to
7e43550
Compare
max-nextcloud
approved these changes
Feb 16, 2026
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Code changes look good to me. Just one minor comment. Did not test it though.
Cypress failures also need to be addressed. I suspect they originate from a dependency update.
mejo-
force-pushed
the
feat/playwright
branch
2 times, most recently
from
e448dbb to
79eadf5
Compare
Signed-off-by: Jonas <jonas@freesources.org>
There is still the possibility of a race condition, that the mountpoint is not setup yet when trying to access the Collectives user folder. It seems to happen more reliably in CI tests, when Nextcloud is spinned up for the first time. Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
…ives Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Fixes opening the file picker dialog with @nextcloud/dialogs >= 7 on Nextcloud 32+31. On Nextcloud 33 it got fixed by nextcloud/server#56941. Before, it failed with the following error stack: ``` at setRef (collectives-main.mjs?v=f606404d-0:20429:22) at patch (collectives-main.mjs?v=f606404d-0:22407:7) at ReactiveEffect.componentUpdateFn [as fn] (collectives-main.mjs?v=f606404d-0:22908:11) at ReactiveEffect.run (collectives-main.mjs?v=f606404d-0:17619:19) at setupRenderEffect (collectives-main.mjs?v=f606404d-0:23011:5) at mountComponent (collectives-main.mjs?v=f606404d-0:22861:7) at processComponent (collectives-main.mjs?v=f606404d-0:22827:9) at patch (collectives-main.mjs?v=f606404d-0:22367:11) at ReactiveEffect.componentUpdateFn [as fn] (collectives-main.mjs?v=f606404d-0:22908:11) at ReactiveEffect.run (collectives-main.mjs?v=f606404d-0:17619:19) ``` Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
feat/playwright
branch
from
79eadf5 to
234af2e
Compare
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
feat/playwright
branch
from
234af2e to
952bd9e
Compare
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)