-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List recent pages and members on landing page #812
Conversation
Passing run #997 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Would only say 2 things:
Show 3 last active members on landing page if it's not a public share.
Why not all until ellipsis is needed? It is nice to see faces. :)
And also a bit more vertical whitespace between the sections would be cool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a brief look at the code. So far everything seems fine. Just have one question.
Signed-off-by: Jonas <jonas@freesources.org>
Disable searching and actions for non-admin users. Signed-off-by: Jonas <jonas@freesources.org>
…Bubble Signed-off-by: Jonas <jonas@freesources.org>
Show list of members on landing page if it's not a public share. Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
* Make sure slider buttons don't interfere with scroll container and only get displayed when desired. Also fix background in active state. * Use animated scrolling, * Use scroll snap API to snap scrolling to beginning of tiles. * Debounce updating of buttons. Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Unfortunately I don't have a good idea here. I'd rather avoid to make the tiles even wider, which would result in less tiles being displayed on narrow screens. And I configured it to be ellipsised on purpose to prevent randomly growing tile width. One option would be to add a line break, like "admin\nseconds ago". What do designers think @jancborchardt @nimishavijay? |
…ontrast Signed-off-by: Jonas <jonas@freesources.org>
Ideas that come to my mind:
|
@max-nextcloud yep, avatar only seems fine. :) |
@mejo- @max-nextcloud I would actually vote for the line break, for the following reasons:
We could instead show the full user bubble on one line and the timestamp on the next line. That way the entire item could be clickable without any issues :) |
vs. Which one do you prefer @nimishavijay @jancborchardt @max-nextcloud 😊 I prefer the avatar only version. With the linebreak it doesn't work well in my eyes. |
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Our landing page doesn't have a title, so let's just reference it as "Landing page". Signed-off-by: Jonas <jonas@freesources.org>
I think I addressed all comments and suggestions for improvements now. See the commit history for details. The screenshot in the PR description is updated, the screencast is not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The headings (main page heading and also "Recent pages", "Collective members" and "Landing page") being grey instead of color-main-text looks a bit off, otherwise all good. :)
* Handle missing pageslider element gracefully. * Calculate `scrollLeftMax` since it's non-standard and only supported on Firefox for now. * Hide scrollbar on Chrome and Edge. Signed-off-by: Jonas <jonas@freesources.org>
🎉🎉🎉 |
📝 Summary
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)