Merge pull request #2286 from nextcloud/fix/chain-condition

Fix chain condition of responses

src/components/ContactDetails.vue

@@ -573,7 +573,7 @@ export default {
 					} catch (error) {
 						if (error.name === 'ParserError') {
 							showError(t('contacts', 'Syntax error. Cannot open the contact.'))
-						} else if (error.status === 404) {
+						} else if (error?.status === 404) {
 							showError(t('contacts', 'The contact doesn\'t exists anymore on the server.'))
 						} else {
 							showError(t('contacts', 'Unable to retrieve the contact from the server, please check your network connection.'))

src/components/ContactDetails/ContactDetailsAvatar.vue

@@ -427,7 +427,7 @@ export default {
 						id: this.contact.addressbook.id,
 						uid: this.contact.uid,
 					}))
-					if (response.status !== 200) {
+					if (response?.status !== 200) {
 						throw new URIError('Download of social profile avatar failed')
 					}
 
@@ -441,7 +441,7 @@ export default {
 					// Notify user
 					showSuccess(t('contacts', 'Avatar downloaded from social network'))
 				} catch (error) {
-					if (error.response.status === 304) {
+					if (error?.response?.status === 304) {
 						showInfo(t('contacts', 'Avatar already up to date'))
 					} else {
 						showError(t('contacts', 'Avatar download failed'))

src/components/MembersList/MembersListItem.vue

@@ -240,7 +240,7 @@ export default {
 					leave: this.isCurrentUser,
 				})
 			} catch (error) {
-				if (error.response.status === 404) {
+				if (error?.response?.status === 404) {
 					this.logger.debug('Member is not in circle')
 					return
 				}

src/store/contacts.js

@@ -370,7 +370,7 @@ const actions = {
 				console.error(error)
 
 				// wrong etag, we most likely have a conflict
-				if (error && error.status === 412) {
+				if (error && error?.status === 412) {
 					// saving the new etag so that the user can manually
 					// trigger a fetchCompleteData without any further errors
 					context.commit('setContactAsConflict', { contact, etag: error.xhr.getResponseHeader('etag') })