Fix 'duplicate types' check for properties with a single type (#1399)

Fix 'duplicate types' check for properties with a single type
nextcloud · Jan 6, 2020 · df8c466 · df8c466
2 parents 783c7a6 + f8435e9
commit df8c466
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/services/checks/duplicateTypes.js b/src/services/checks/duplicateTypes.js
@@ -26,12 +26,9 @@ export default {
 		try {
 			const props = contact.vCard.getAllProperties()
 				.map(prop => prop.getParameter('type'))
-				.filter(prop => prop)
+				.filter(prop => Array.isArray(prop))
 			const fixed = props.map(prop => [...new Set(prop)])
-			if (props
-				&& Array.isArray(props)
-				&& props.length > 0
-				&& props.join('') !== fixed.join('')) {
+			if (props.join('') !== fixed.join('')) {
 				return true
 			}
 		} catch (error) {