Too easy to delete contact

[ralxxx]

Is your feature request related to a problem? Please describe.
Currently it is very easy to delete a contact from the web backend. - just by clicking on the trash can next to the contact name in the contact list. The risk is that contacts are deleted by mistake.

Describe the solution you'd like
As it is rather the exception that a contact is being deleted from the contact list, I would prefer if a contact could be deleted only by clicking first on the contact itself and then on the three dots in the upper right corner (and finally confirming by deleting contact).

Additional context

There's a link to another issue raised earlier: nextcloud/server#18181

[skjnldsv]

@jancborchardt shall we add a confirm? An undo (cc #637)? Both?
Add a separator?

[lfischer]

Hello,
I would prefer a mandatory confirmation as minimum.

[jancborchardt]

I agree that the trash action in the AppContentList is too much. It should only be in the 3-dot menu in the detail view.

This will already solve the biggest problem. Undo is a thing we should look into as well of course, but that’s separate.

[jancborchardt]

If someone wants to submit a pull request to fix this, the only thing to do is simply to delete the following lines which are for the delete action:

contacts/src/components/ContactsList/ContactsListItem.vue

Lines 30 to 35 in 4d3c86d

	<!-- undo actions -->
	<div v-if="!contact.addressbook.readOnly && !deleteTimeout"
	class="icon-delete"
	tabindex="0"
	@click.prevent.stop="deleteContact"
	@keypress.enter.prevent.stop="deleteContact" />

Marking this as good first issue :)

[skjnldsv]

If someone wants to submit a pull request to fix this, the only thing to do is simply to delete the following lines which are for the delete action:

this one is about the delete from top right menu @jancborchardt I think :)
So deleting the undo entry will not make it easier to delete
Also, it would make the undo action impossible

[jancborchardt]

If someone wants to submit a pull request to fix this, the only thing to do is simply to delete the following lines which are for the delete action:

this one is about the delete from top right menu @jancborchardt I think :)

No, @ralxxx said (emphasis mine) ;)

Currently it is very easy to delete a contact from the web backend. - just by clicking on the trash can next to the contact name in the contact list.

Including the first screenshot of the circled trash cans. :)

[skjnldsv]

I bought new 👓 ! 🙈
So we should remove the delete button from the list directly? Is it what you were trying to do with this ?

If someone wants to submit a pull request to fix this, the only thing to do is simply to delete the following lines which are for the delete action:

contacts/src/components/ContactsList/ContactsListItem.vue

Lines 30 to 35 in 4d3c86d

	<!-- undo actions -->
	<div v-if="!contact.addressbook.readOnly && !deleteTimeout"
	class="icon-delete"
	tabindex="0"
	@click.prevent.stop="deleteContact"
	@keypress.enter.prevent.stop="deleteContact" />

[jancborchardt]

@skjnldsv exactly. :) I think this will be the simple fix. (The "Delete" action in the 3-dot menu of the detail view is totally fine, and not so easy to accidentally click.)

[skjnldsv]

Then it's also a matter of removing the delete method/logic and undo methods/logic in the contacts/src/components/ContactsList/ContactsListItem.vue component :)
Not just removing the undo but also the delete entries 👍

[jancborchardt]

Pull request open at #1430 → please review :)