Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement for alphabetic sorting of groups if there are numbers #1598

Closed
jancborchardt opened this issue Apr 22, 2020 · 0 comments · Fixed by #1788
Closed

Enhancement for alphabetic sorting of groups if there are numbers #1598

jancborchardt opened this issue Apr 22, 2020 · 0 comments · Fixed by #1788
Labels
3. to review Waiting for reviews enhancement New feature or request good first issue Good for newcomers
Milestone
3.4.0

Comments

@jancborchardt
Copy link
Member

As a follow-up to #1461 by @ImUrX, when group names start with numbers, the sorting is unexpected:
Contact groups number sorting

Expected would be by value, not by first character:

  • 5
  • 20
  • 50
  • 150

Seems a compareFunction is needed for that: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort
@jancborchardt jancborchardt added enhancement New feature or request 1. to develop Accepted and waiting to be taken care of good first issue Good for newcomers labels Apr 22, 2020
@jancborchardt jancborchardt mentioned this issue Apr 22, 2020
Closed
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Sep 6, 2020
@skjnldsv skjnldsv mentioned this issue Sep 6, 2020
Merged
@skjnldsv skjnldsv added this to the 3.4.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
3.4.0
Development

Successfully merging a pull request may close this issue.

Properly sort groups nextcloud/contacts
2 participants
@jancborchardt @skjnldsv