Sort groups alphabetically instead of by amount of contacts

[ImUrX]

Just redid the branch of #1451 because accidentaly deleted package-lock.json
This PR should fix #522
I still would like to test this on windows, I dont know how to do so, I just been reading the code a lot to see if I'm doing something wrong :p

[codecov]

Codecov Report

Merging #1461 into master will increase coverage by 4.84%.
The diff coverage is 40.00%.

@@             Coverage Diff              @@
##             master    #1461      +/-   ##
============================================
+ Coverage     62.31%   67.16%   +4.84%     
- Complexity        0       15      +15     
============================================
  Files             4        5       +1     
  Lines            69       67       -2     
============================================
+ Hits             43       45       +2     
+ Misses           26       22       -4     

Impacted Files	Coverage Δ	Complexity Δ
appinfo/app.php	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
lib/AppInfo/Application.php	0.00% <0.00%> (ø)	2.00 <2.00> (?)
lib/Controller/PageController.php	100.00% <100.00%> (+20.00%)	2.00 <1.00> (+2.00)
lib/ContactsMenu/Providers/DetailsProvider.php	96.87% <0.00%> (+10.76%)	11.00% <0.00%> (+11.00%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df46053...c7079d1. Read the comment docs.

[skjnldsv]

Great! :)
To answer your other question, it should be default as it is (by count then fallback by name)

Thanks again, super great having awesome contributors like you! 🤗

[skjnldsv]

See comments :)

[ImUrX]

yay, lets hope the PR does what it should do

[skjnldsv]

• No default selected and changing doesn't work (no error in logs)
  
• Hard to differentiate the two dropdown for contacts and groups sorting. Shall we split with the import dropdown above and change the labels? `Sort contacts by xxx', 'Sort groups by xxx' ?

[jancborchardt]

Getting a different console error now, navigation not showing up either ;)

[Vue warn]: Error in render: "TypeError: matchB is null"

found in

---> <Contacts> at src/views/Contacts.vue
       <ContactsRoot> at src/ContactsRoot.vue
         <Root> vue.runtime.esm.js:619
TypeError: "matchB is null"
    menu Contacts.vue:277
    groupsMenu Contacts.vue:273
    VueJS 3
    menu Contacts.vue:291
    VueJS 4
    render Contacts.vue:31
    VueJS 7
vue.runtime.esm.js:1888

[ImUrX]

i tried to detect the null with a nor but i should have used a nand

[jancborchardt]

Now it works but one group with a "V" is sorted up top? (Has 1 person if that is relevant.)

[ImUrX]

mmm this needs debugging but idk how to compile this. The weird part is that the only thing that should be pulled up first is group.name === t('contactsinteraction', 'Recently contacted')

[jancborchardt]

Hmm, actually "recently contacted" doesn't show in the list at all. Did I miss anything except checking out the branch and npm ci && npm run dev?

[ImUrX]

No idea honestly, been trying to figure it out myself

[jancborchardt]

Any idea @nextcloud/contacts?

[jancborchardt]

Now it works but one group with a "V" is sorted up top?

For reference: If I delete that group, the next one from the end of the alphabet is shown there. "Recently contacted" is not there, and I’m guessing the bug has to do with that.

[ImUrX]

if there is no group with the name Recently Contacted then findIndex should be returning -1, slice shouldnt do anything with -1 tho.

[jancborchardt]

@ImUrX very nice, works well now! :) Could you squash your commits into one, and also sign the commit? (You can sign the commit retroactively via git commit --amend -s.)

[jancborchardt]

And @call-me-matt could you also look over the code? :)

@ImUrX we have a chat channel for Contacts app contributors, would you like to be invited there? :)

[ImUrX]

yeah sure

[jancborchardt]

Works very nicely design-wise, but needs a code review @nextcloud/contacts :)

[skjnldsv]

Hey!
This will be merged part of the new group enhancement pull request because I changed the way roups menu is generated! I will use your logic because I find it clean :)
So don't worry if this is just getting closed and not merged, this will be part of #1687