-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort groups alphabetically #1451
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1451 +/- ##
=======================================
Coverage 62.31% 62.31%
=======================================
Files 4 4
Lines 69 69
=======================================
Hits 43 43
Misses 26 26 Continue to review full report at Codecov.
|
Signed-off-by: ImUrX <urielfontan2002@gmail.com>
Hi, and thanks for your pr! :) |
Sure, but which one would be the default one?
…On Saturday, February 1, 2020, John Molakvoæ ***@***.***> wrote:
Hi, and thanks for your pr! :)
So, instead of changing the behaviour entirely, I would suggest adding a
setting under the contacts sorting dropdown (in the bottom left settings
area)
What do you think?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1451?email_source=notifications&email_token=AA4G4POPRJO73IIQ3XO2YBLRAVOJFA5CNFSM4KODULG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKQ3FZY#issuecomment-581022439>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4G4POC42NJF3VS4MBSQJTRAVOJFANCNFSM4KODULGQ>
.
|
…calstorage key, add sortGroups in store, use sortGroups each time group menu is generated (maybe refactor that a little?)
Signed-off-by: ImUrX <urielfontan2002@gmail.com>
i accidentaly deleted package-lock.json :/ |
Gonna remake the whole branch so it’s a little more clean |
I think the entries for "All contacts" and "Contacts without group" should be at the top of the list, just like it's now, and below should be a list of all groups, sorted by name. I don't know what determines the sequence of groups if they are not sorted by name (as it's now, unfortunately). This is just confusing if you have many groups, and below them groups like "colleagues-local" "colleagues-external", colleagues-formerly", etc. And, by the way, when editing a contact, also the selection box should where you can assign the groups should provide the list of group names sorted by name, IMO. |
Refers to #522
I did the solution just giving sort no arguments and overriding toString to each group's name.
Would like to test, but I dont have any idea on how to do so.