Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10n: Unfinished string text in Transifex #1851

Closed
Valdnet opened this issue Oct 14, 2020 · 12 comments · Fixed by #1892 or #1893
Closed

l10n: Unfinished string text in Transifex #1851

Valdnet opened this issue Oct 14, 2020 · 12 comments · Fixed by #1892 or #1893
Labels
0. Needs triage bug Something isn't working

Comments

@Valdnet
Copy link
Contributor

Valdnet commented Oct 14, 2020

In Transifex there is an unfinished string text for:

{{ t('contacts', `Import into the '{addressbookName}' addressbook`, { addressbookName: option.displayName }) }}

The sentence ends with: Import into the .

{{ t('contacts', `You don't have any contacts yet`) }}

The sentence ends with: You don.

@Valdnet Valdnet added bug Something isn't working 0. Needs triage labels Oct 14, 2020
@skjnldsv
Copy link
Member

@MorrisJobke @ChristophWurst @juliushaertl the bot doesn't like this?

@ChristophWurst
Copy link
Member

Apparently. Change `You don't have any contacts yet` to 'You don\'t have any contacts yet'

@skjnldsv
Copy link
Member

I don\'t wanna!

@ChristophWurst
Copy link
Member

👁️ 👄 👁️

@MorrisJobke
Copy link
Member

I don't wanna!

Then you need to fix gettext as this is what we are using: https://github.com/nextcloud/docker-ci/blob/master/translations/translationtool/src/translationtool.php#L75-L98

@Valdnet
Copy link
Contributor Author

Valdnet commented Oct 23, 2020

@skjnldsv Are you running on a fix? In Transifex, I'd like to translate it 😉.

@skjnldsv
Copy link
Member

No, haven't done it yet,

Valdnet added a commit that referenced this issue Oct 27, 2020
Valdnet added a commit that referenced this issue Oct 27, 2020
@Valdnet
Copy link
Contributor Author

Valdnet commented Oct 27, 2020

@skjnldsv What will we do about it? I tried to convert ' to " but I'm not sure if you can use " in vue.
Then, to use \ in the latter case, think about it gettext.

Translators are waiting for a quick fix as they cannot fully translate the project 😉.

@skjnldsv
Copy link
Member

You can use them, but it's just a matter of string parsing.
In forms we do not use quotes to mention forms names. Let's do the same here. Let's just simply remove the quotes around the name.

@Valdnet
Copy link
Contributor Author

Valdnet commented Oct 27, 2020

Let's just simply remove the quotes around the name.

I thought so too, but I didn't know if you would agree to it 😉.

@skjnldsv Please approval PR: #1892.

@Valdnet
Copy link
Contributor Author

Valdnet commented Oct 27, 2020

@skjnldsv It still remains to be corrected:

{{ t('contacts', `You don't have any contacts yet`) }}

Maybe rebuild a sentence?
You don't have any contacts yet -> There are no contacts yet
😁

@Valdnet Valdnet reopened this Oct 27, 2020
Valdnet added a commit that referenced this issue Oct 27, 2020
@Valdnet
Copy link
Contributor Author

Valdnet commented Oct 27, 2020

@skjnldsv If you agree, approve PR: #1893 and close issue again 😉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage bug Something isn't working
Projects
None yet
5 participants