Properly format displayName and fields validation

[skjnldsv]

Fix #824
Fix #823
Fix #848

@j-ed @plmrn

Unsigned test build: contacts.tar.gz

[codecov]

Codecov Report

Merging #880 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #880   +/-   ##
=======================================
  Coverage   64.91%   64.91%           
=======================================
  Files           4        4           
  Lines          57       57           
=======================================
  Hits           37       37           
  Misses         20       20

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b3d292...1f86484. Read the comment docs.

[ChristophWurst]

🐘

[plmrn]

Tested on Firefox with cleared cache and Safari (which I never use so cache clear as well).

All contacts are not displaying anymore :)

Let me know if you need more info
Thanks a lot

EDIT : the info message that displays on top center of the screen reads "The contact no longer exists on the server"

[skjnldsv]

@plmrn That is interesting ^^'
Please paste your browser logs here :)

[plmrn]

@skjnldsv Yes, and to be fair I think it does take care of the problem, although not exactly the way I intended it a first ;)

I don't know exactly what you mean by "browser logs". Here is the content of Firefox's "console" on the contacts page of the cloud:

JQMIGRATE: Migrate is installed, version 1.4.0 jquery-migrate.min.js:2:542
New search handler registered search.js:67:4
Connected to dav!
Object { rootUrl: Getter & Setter, advertisedFeatures: Getter & Setter, currentUserPrincipal: Getter & Setter, principalCollections: Getter & Setter, calendarHomes: Getter & Setter, addressBookHomes: Getter & Setter, parser: Getter & Setter, _isConnected: Getter & Setter, _request: Getter & Setter, … }
Contacts.vue:238
TypeError: "r.join is not a function"
get https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:156:2865
sortedContacts https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:112:2432
sortContacts https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:112:2399
We https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:41:33665
commit https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:47:640
commit https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:47:618
_withCommit https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:47:2143
commit https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:47:590
commit https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:41:31431
t https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:91:5248
L https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:276:27677
L https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:276:27545
c https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:276:35404
addressbooks.js:385:4

Do you need anything else? Let me know :)

[skjnldsv]

@plmrn thanks a lot!
Please try this one (it will still throw an error) but I added an additional debug.
contacts.tar.gz

[plmrn]

Here goes, redacted for privacy purposes (the array of contacts seemed exhaustive before I trimmed it)

JQMIGRATE: Migrate is installed, version 1.4.0 jquery-migrate.min.js:2:542
New search handler registered search.js:67:4
You are running Vue in development mode.
Make sure to turn on production mode when deploying for production.
See more tips at https://vuejs.org/guide/deployment.html vue.runtime.esm.js:8096
Connected to dav!
{…}
​
ob: Object { value: {…}, dep: {…}, vmCount: 0 }
​
_isConnected: Getter & Setter
​
_request: Getter & Setter
​
addressBookHomes: Getter & Setter
​
advertisedFeatures: Getter & Setter
​
calendarHomes: Getter & Setter
​
currentUserPrincipal: Getter & Setter
​
parser: Getter & Setter
​
principalCollections: Getter & Setter
​
rootUrl: Getter & Setter
​
: Object { … }
Contacts.vue:249
null contact.js:350
Array(5) [ "LAST NAME", "FIRST NAME", "", "", "" ]
contact.js:350
null contact.js:350
TypeError: "org.join is not a function"
get https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:43541:18
sortedContacts https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:45500:9
sortContacts https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:45497:8
wrappedMutationHandler https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:41132:5
commitIterator https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:40800:7
commit https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:40799:5
_withCommit https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:40930:3
commit https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:40798:3
boundCommit https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:40743:12
_callee6$/< https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:44921:17
N https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:19545:27674
N https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:19545:27542
u https://cloud.paulmorin.fr/apps/contacts/js/contacts.js:19545:35405
addressbooks.js:530

[skjnldsv]

@plmrn should be fixed in :)
contacts.tar.gz

Thanks for your help!! 🤗

[plmrn]

Perfect, thanks for the time!