Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Salutation is not suppressed in list view anymore since vue.js #823

Closed
j-ed opened this issue Jan 5, 2019 · 1 comment
Closed

Salutation is not suppressed in list view anymore since vue.js #823

j-ed opened this issue Jan 5, 2019 · 1 comment
Labels
1. to develop Accepted and waiting to be taken care of regression Regression of a previous working feature
Milestone
3.0.3

Comments

@j-ed
Copy link

j-ed commented Jan 5, 2019 •
edited by jospoortvliet
Loading

Expected behavior

If you've decided to sort your contact list based on the first or last name, the salutation should usually be suppressed in the contact list view, like:

  • Sort by first name -> FIRST LAST
  • Sort by last name -> LAST, FIRT
  • Sort by display name -> SALUTATION FIRST LAST

Current behavior

Independently which sort order of your contact list you've chosen the display name is always shown.
(I compared the behavior with v2.1.8 in which everything worked as expected)

20190105_nc_contacts_sort_order

Steps to reproduce

  1. Open the Contacts app
  2. Switch between the available sort orders and check how the contact names are listed.

Environment

Server Configuration

OS: Linux 3.16.50
Web server: Apache2 2.4.37
Database: MariaDB 10.2.19
PHP version: 7.2.13
Nextcloud version: 15.0.0
Contacts app version: 3.0.1

Client Configuration

Browser: Mozilla Firefox 64.0
Operating system: Windows 10

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@nextcloud-bot nextcloud-bot added the regression Regression of a previous working feature label Jan 5, 2019
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #821 (Displayed name field not automatically populated since vue.js), #780 (vcard gender not working properly since vue.js), #641 (Vue avatars in list), #604 ([Vue] Avatars in list), and #627 ([Vue] Download contact in details view).

@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Jan 5, 2019
@skjnldsv skjnldsv added this to the 3.1.0 milestone Jan 5, 2019
@skjnldsv skjnldsv mentioned this issue Jan 25, 2019
Merged
@skjnldsv skjnldsv modified the milestones: next minor, 3.1.0, 3.0.3 Apr 8, 2019
skjnldsv pushed a commit that referenced this issue Apr 28, 2019
@dependabot @skjnldsv
Bump webpack-cli from 3.3.0 to 3.3.1 (#1077)
aef4de8 
Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 3.3.0 to 3.3.1.
<details>
<summary>Release notes</summary>

*Sourced from [webpack-cli's releases](https://github.com/webpack/webpack-cli/releases).*

> ## Webpack-CLI v.3.3.1
> Version 3.3.1 comes with infrastructure fixes and various of improvements to the repository. Full changelog found [here](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md#331-2019-04-21)
</details>
<details>
<summary>Changelog</summary>

*Sourced from [webpack-cli's changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md).*

> # 3.3.1 (2019-04-21)
> [Full Changelog](webpack/webpack-cli@v0.1.5...v3.3.1)
> 
> ## New Features
> 
> * terser: clean old files ([89e6b74](webpack/webpack-cli@89e6b74))
> * terser: remove leftover files ([27d5b4d](webpack/webpack-cli@27d5b4d))
> * terser: replace after merging master ([c404655](webpack/webpack-cli@c404655))
> * replace Uglify with Terser in generators ([2b8651b](webpack/webpack-cli@2b8651b))
> * use terserPlugin in loaderOptionsPlugin ([14f5337](webpack/webpack-cli@14f5337))
> * use terserJsPlugin for transformations during migrate ([33c6185](webpack/webpack-cli@33c6185))
> * replace uglifyJsPlugin with terserPlugin in migrate ([d467f3b](webpack/webpack-cli@d467f3b))
> * opencollective prompt: work on windows setting atime by code ([3af73a8](webpack/webpack-cli@3af73a8))
> * opencollective prompt: fix typo ([c2351b1](webpack/webpack-cli@c2351b1))
> * opencollective prompt: remove .lastocprint file from fs ([b96ad56](webpack/webpack-cli@b96ad56))
> * opencollective prompt: extract weekday to variable ([790d27a](webpack/webpack-cli@790d27a))
> * opencollective prompt: set terminal cols to 80 ([badc32d](webpack/webpack-cli@badc32d))
> * opencollective prompt: fix azure ci ([ea0039a](webpack/webpack-cli@ea0039a))
> * opencollective prompt: lint ([ea906d8](webpack/webpack-cli@ea906d8))
> * opencollective prompt: clear package.json modifications ([f080733](webpack/webpack-cli@f080733))
> * opencollective prompt: add prompt in postinstall script ([dd9d528](webpack/webpack-cli@dd9d528))
> 
> ## Ast
> 
> * change tooltip property from uglify to terser ([ea9e4b8](webpack/webpack-cli@ea9e4b8))
> * replace requires and inits for uglify with terser ([3011a6c](webpack/webpack-cli@3011a6c))
> * replace UglifyJsPlugin with TerserPlugin ([21da35f](webpack/webpack-cli@21da35f))
> 
> ## Chore
> 
> * cli: move constants to a separate file ([#798](https://github-redirect.dependabot.com/webpack/webpack-cli/pull/798))
> * deps: upgrade lerna to fix vulnerabilities & update webpack-dev-server ([#823](https://github-redirect.dependabot.com/webpack/webpack-cli/pull/823))
> * docs: removes scaffolding docs from the root ([8c1db03](webpack/webpack-cli@8c1db03))
> * junit: reverting the junit.xml ([80fd4fa](webpack/webpack-cli@80fd4fa))
> * tests: updated test regex, some helper scripts ([#809](https://github-redirect.dependabot.com/webpack/webpack-cli/pull/809))
> * types: add type information ([#791](https://github-redirect.dependabot.com/webpack/webpack-cli/pull/791))
> * replace instances of uglify with terser ([f9cb8ce](webpack/webpack-cli@f9cb8ce))
> * use actual package name in comment about removing uglify ([b1cf4cc](webpack/webpack-cli@b1cf4cc))
> * align file in the same way as other terserPlugin test fixtures ([b6c6484](webpack/webpack-cli@b6c6484))
> * remove gitHash from package.json ([2af08be](webpack/webpack-cli@2af08be))
> 
> ## Docs
> 
> * contributing: fixes dead  link ([#835](https://github-redirect.dependabot.com/webpack/webpack-cli/pull/835))
> * opencollective prompt: improve code clarity ([55992a4](webpack/webpack-cli@55992a4))
> * packages: adds downloads/month shield ([6a0375a](webpack/webpack-cli@6a0375a))
> * readme: adds contributors shield ([958d064](webpack/webpack-cli@958d064))
> * README: phrase change ([3a11a16](webpack/webpack-cli@3a11a16))
> * README: add link to webpack-scaffold-starter ([e35a194](webpack/webpack-cli@e35a194))
> * README: update scaffolding links ([74179b5](webpack/webpack-cli@74179b5))
></tr></table> ... (truncated)
</details>
<details>
<summary>Commits</summary>

- [`d3f8e20`](webpack/webpack-cli@d3f8e20) chore: v.3.1.1
- [`f371e72`](webpack/webpack-cli@f371e72) Merge pull request [#847](https://github-redirect.dependabot.com/webpack/webpack-cli/issues/847) from anshumanv/846
- [`da9e732`](webpack/webpack-cli@da9e732) Merge pull request [#841](https://github-redirect.dependabot.com/webpack/webpack-cli/issues/841) from pranshuchittora/docs-remove
- [`cb68b1b`](webpack/webpack-cli@cb68b1b) docs(serve): link to webpack-dev-server
- [`f7451d4`](webpack/webpack-cli@f7451d4) docs(serve): update docs to use webpack-dev-server
- [`06b4929`](webpack/webpack-cli@06b4929) Remove tslint in favour of eslint ([#834](https://github-redirect.dependabot.com/webpack/webpack-cli/issues/834))
- [`8c1db03`](webpack/webpack-cli@8c1db03) chore(docs): removes scaffolding docs from the root
- [`dc941e6`](webpack/webpack-cli@dc941e6) docs(contributing): fixes dead  link ([#835](https://github-redirect.dependabot.com/webpack/webpack-cli/issues/835))
- [`b8d5511`](webpack/webpack-cli@b8d5511) Merge pull request [#832](https://github-redirect.dependabot.com/webpack/webpack-cli/issues/832) from pranshuchittora/docs
- [`6a0375a`](webpack/webpack-cli@6a0375a) docs(packages): adds downloads/month shield
- Additional commits viewable in [compare view](webpack/webpack-cli@v.3.3.0...v.3.3.1)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=webpack-cli&package-manager=npm_and_yarn&previous-version=3.3.0&new-version=3.3.1)](https://dependabot.com/compatibility-score.html?dependency-name=webpack-cli&package-manager=npm_and_yarn&previous-version=3.3.0&new-version=3.3.1)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @skjnldsv.

[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of regression Regression of a previous working feature
Projects
None yet
Milestone
3.0.3
Development

No branches or pull requests
3 participants
@j-ed @skjnldsv @nextcloud-bot