Vue avatars in list #641
Merged
Vue avatars in list #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleepypioneer
added
3. to review
skjnldsv
reviewed
Sep 25, 2018
| @@ -48,6 +45,16 @@ export default { | |||
| } catch (e) { | |||
| return 'grey' | |||
| } | |||
| }, | |||
| avatarUrl() { | |||
| return 'url(' + this.contact.url + '?photo' + ')' | |||
There was a problem hiding this comment.
Small tip, with latest javascript you can do
`url(${this.contact.url}?photo)`There was a problem hiding this comment.
Cool very nice, anything else here to change?
There was a problem hiding this comment.
I'll rebase your branch in a second :)
|
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
approved these changes
Sep 25, 2018
| return `url(${this.contact.url}?photo)` | ||
| }, | ||
| initial() { | ||
| if (this.avatarUrl) { |
There was a problem hiding this comment.
A contact always have an url. You cannot assume the contact have a picture or not.
If a contact does NOT have an url, that means it's a local contact (present on the store only and not created on the server yet) that have not yet been pushed to the server. So in that case, yes we can assume it doesn't have an url. Though I'll suggest checking the contact.dav property to check if this is a local contact or not.
|
|
|
Nice work 🎖 sorry for the messy errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #604 Proposed code for adding avatars in list without needing to check contact.photo using contact.url?photo.
I condensed the two divs and set them to return values based on if an url was returned or not.
I removed the filter as it was simpler to return
this.contact.displayName.charAt(0)or '' for the initial value.