Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcard gender not working properly since vue.js #780

Closed
hirschrobert opened this issue Dec 20, 2018 · 8 comments
Closed

vcard gender not working properly since vue.js #780

hirschrobert opened this issue Dec 20, 2018 · 8 comments
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@hirschrobert
Copy link
Contributor

hirschrobert commented Dec 20, 2018

can someone give some hints, since i am new to vue.js? (@skjnldsv )

vcard GENDER has no type parameter according to rfc 6350, but here is saved with one(GENDER;TYPE=F: instead of GENDER:F). this probably leads to the superfluous input text field. just the select field with the three options ("female", "male", "other") would be enough.

property heading "Gender" in the view is missing, too. Or some hint what this field is supposed to save.

further the question, how a single gender value (i.e. female) can be saved with both GENDER:F and X-WAB-GENDER:1? This is necessary for i.e. MS Outlook compatibility.

thanks!
(this is an update for issue #214 )


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@hirschrobert hirschrobert added enhancement New feature or request help wanted Extra attention is needed design Related to the design compatibility Compatibility with other services labels Dec 20, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #108 (provide vcard GENDER field), #45 (Update vcard js lib), #324 (VCard version), #601 (Vue import progress), and #219 (Contacts not working with NC12).

@donvipre
Copy link

This issue occurs since Nextcloud 15.0.0 Contacts 3.0.0 app as well.

@skjnldsv skjnldsv added bug Something isn't working 1. to develop Accepted and waiting to be taken care of and removed compatibility Compatibility with other services design Related to the design enhancement New feature or request labels Dec 31, 2018
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jan 9, 2019
@skjnldsv skjnldsv added this to the 3.0.2 milestone Jan 9, 2019
@skjnldsv
Copy link
Member

skjnldsv commented Jan 9, 2019

further the question, how a single gender value (i.e. female) can be saved with both GENDER:F and X-WAB-GENDER:1? This is necessary for i.e. MS Outlook compatibility.

Please open another ticket for that. This is a separate discussion that needs to be discussed.

@hirschrobert
Copy link
Contributor Author

actually this is not solved. the entry is again GENDER;TYPE=M: and thus not rfc conform, see my initial comment. it needs to be saved as GENDER:M. in my last commit it worked.

@hirschrobert hirschrobert reopened this Jan 9, 2019
@skjnldsv
Copy link
Member

Raah, dammit you're right! I read the rfc too fast and butchered your pr! 😞
Shall we revert it?

@hirschrobert
Copy link
Contributor Author

i dont mind continuing with the latest master branch. but i havent figured out the logic of it in detail, yet.

but nextcloud-vue 0.5.0 still gives error
TypeError: nextcloud_vue__WEBPACK_IMPORTED_MODULE_2__.DatetimePicker.methods is undefined
even on the latest master branches of server and contacts, making the whole contacts app crash (see also here). when i set nextcloud-vue back to 0.4.6. in the contacts package.json manually, it works. so would you set it back until it is fixed?

@skjnldsv
Copy link
Member

I'd rather revert the pull request first. I'm not happy with what I did. :)
I will then push a fix for the Datepicker.

@skjnldsv
Copy link
Member

@hirschrobert master is fixed now! The datepicker does not cause any more issue :)

@skjnldsv skjnldsv removed this from the 3.0.2 milestone Jan 21, 2019
@skjnldsv skjnldsv added this to the next milestone Jan 21, 2019
@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 3. to review Waiting for reviews labels Jan 21, 2019
@skjnldsv skjnldsv modified the milestones: next, 3.0.4 Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants