Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datepicker dark mode #193

Merged
merged 2 commits into from
Jan 7, 2019
Merged

Datepicker dark mode #193

merged 2 commits into from
Jan 7, 2019

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Jan 7, 2019 •
edited
Loading

Require nextcloud/server#13403

Created an automated font generation that gets applied to the scss.
That way we don't care about the dark theme, it gets automatically changed with the color attribute! 😍

capture d ecran_2019-01-07_13-41-45

@skjnldsv skjnldsv added enhancement New feature or request 2. developing Work in progress design Design, UX, interface and interaction design labels Jan 7, 2019
@skjnldsv skjnldsv added this to the 0.4.7 milestone Jan 7, 2019
@skjnldsv skjnldsv self-assigned this Jan 7, 2019
@skjnldsv skjnldsv force-pushed the datepicker-dark-mode branch from 96cd16c to 53218e2 Compare January 7, 2019 12:38
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 7, 2019
ChristophWurst
ChristophWurst approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🐘

@ChristophWurst
Copy link
Contributor

Conflicting files

package-lock.json
package.json
src/assets/arrow-left-double.svg
src/assets/arrow-left.svg
src/assets/arrow-right-double.svg
src/assets/arrow-right.svg
src/components/DatetimePicker/DatetimePicker.vue
src/components/DatetimePicker/index.scss

🙈

@skjnldsv skjnldsv force-pushed the datepicker-dark-mode branch from 16a6af4 to 5ff54d0 Compare January 7, 2019 15:42
@ChristophWurst
Copy link
Contributor

Conflicting files

package-lock.json

well well well

@skjnldsv skjnldsv force-pushed the datepicker-dark-mode branch from a84ec1a to 2229746 Compare January 7, 2019 15:54
@skjnldsv
Dark mode fixes
9d3a00c 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Icon font
6a740ce 
Remove unused dependency
Stylelint ignore fonts and webpack fixes

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the datepicker-dark-mode branch from 2229746 to 6a740ce Compare January 7, 2019 16:07
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 7, 2019
@skjnldsv skjnldsv merged commit 4d33372 into master Jan 7, 2019
@skjnldsv skjnldsv deleted the datepicker-dark-mode branch January 7, 2019 16:23
@skjnldsv skjnldsv mentioned this pull request Jan 8, 2019
Closed
@hirschrobert
Copy link

could be related error nextcloud/contacts@e1ec0b4#r31889831

@raimund-schluessler
Copy link
Contributor

Require nextcloud/server#13403

This means, apps that use the datepicker component require >=NC15, although they would work perfectly fine on NC14 otherwise!?

@ChristophWurst
Copy link
Contributor

Reminds me that we should have a clear range of supported server versions in this library.

@ChristophWurst ChristophWurst mentioned this pull request Jan 10, 2019
Closed
@skjnldsv
Copy link
Contributor Author

@raimund-schluessler yes! Actually that was always the plan. All of our apps migrations supports min 15 :)

@skjnldsv skjnldsv mentioned this pull request Jan 10, 2019
Merged
@raimund-schluessler
Copy link
Contributor

@raimund-schluessler yes! Actually that was always the plan. All of our apps migrations supports min 15 :)

Ok, fine with me.

@hirschrobert hirschrobert mentioned this pull request Jan 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UX, interface and interaction design enhancement New feature or request
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @ChristophWurst @hirschrobert @raimund-schluessler