Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide gender field #214

Merged
merged 13 commits into from
Aug 25, 2017
Merged

provide gender field #214

merged 13 commits into from
Aug 25, 2017

Conversation

hirschrobert
Copy link
Contributor

tried to contribute to my issue #108 . If you could have a look at it. am new here and hope it is the right track. many thanks

@hirschrobert
provide gender field
7b5abba 
most common fields according to https://tools.ietf.org/html/rfc6350#section-6.2.7. from my issue nextcloud#108
additonally template "select" needs to be added.
sorry for any mistakes, i am new here
@hirschrobert
Create select.html
2e59458 
new template for gender field
@codecov
Copy link

codecov bot commented May 13, 2017 •
edited
Loading

Codecov Report

Merging #214 into master will decrease coverage by 1.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #214     +/-   ##
=========================================
- Coverage   15.58%   14.38%   -1.2%     
=========================================
  Files          52       55      +3     
  Lines        1142     1251    +109     
=========================================
+ Hits          178      180      +2     
- Misses        964     1071    +107
Impacted Files Coverage Δ
js/models/contact_model.js 40.39% <ø> (-0.61%) ⬇️
js/services/vCardProperties.js 18.18% <ø> (ø) ⬆️
...mponents/contactImport/contactImport_controller.js 6.25% <0%> (-27.09%) ⬇️
js/components/datepicker_directive.js 7.69% <0%> (-8.98%) ⬇️
...omponents/contactImport/contactImport_directive.js 2.94% <0%> (-2.95%) ⬇️
...s/components/contactList/contactList_controller.js 0.83% <0%> (-0.94%) ⬇️
js/components/groupList/groupList_controller.js 6.25% <0%> (-0.42%) ⬇️
...s/components/detailsItem/detailsItem_controller.js 1.56% <0%> (-0.23%) ⬇️
js/services/contact_service.js 0.59% <0%> (-0.15%) ⬇️
js/services/addressBook_service.js 1.03% <0%> (-0.09%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94fe8e8...888db5a. Read the comment docs.

@MariusBluem
Copy link
Member

Well ... Do you have some example clients who render the gender in your vCard?

Especially the non-male/female part 🤔 ... I think we should replace this with something like "other" or whatever those CardDAV-clients do ;)

@hirschrobert
Copy link
Contributor Author

when i download it in nextcloud it gives this file: a94d959f-a9e9-4d18-b887-4664370e4eda-4.vcf.txt

According to https://tools.ietf.org/html/rfc6350#section-6.2.7 that seem to be right.

MariusBluem
MariusBluem reviewed May 13, 2017
View reviewed changes
l10n/de_DE.js Outdated
"Gender" : "Geschlecht",
"Male" : "männlich",
"Female" : "weiblich",
"intersex" : "intersexuell"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translations are handled over Transifex 🙈

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. do i understand this right? I don't need to take care of translation? Your server is doing the scanning of new labels, pushes it to transifex, your crew will translate it and pushes it to github? All automatically? Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hirschrobert That's correct - you just have to add "t('contacts', ...)" in the code and the rest is handled automatically.

@skjnldsv
Copy link
Member

No, don't delete the files, delete the edit from the commit :)

@xh3n1
Copy link
Member

xh3n1 commented Jul 18, 2017

Female
Male
None
Other
Unknown

@MariusBluem
Copy link
Member

MariusBluem commented Aug 25, 2017 •
edited
Loading

Male
Female
Other

None/Unknown can be done by simply not adding this gender-field. Discussed with @hirschrobert

MariusBluem and others added 2 commits August 25, 2017 11:45
nickvergessen
nickvergessen approved these changes Aug 25, 2017
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@jonatoni
Copy link
Member

thanks @nickvergessen 😜

@MariusBluem MariusBluem merged commit 174e6dc into nextcloud:master Aug 25, 2017
@MariusBluem
Copy link
Member

Thanks for contributing 🙈

@hirschrobert hirschrobert mentioned this pull request Dec 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusBluem MariusBluem MariusBluem left review comments

@irgendwie irgendwie irgendwie left review comments

@jonatoni jonatoni jonatoni approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hirschrobert @MariusBluem @skjnldsv @xh3n1 @jonatoni @nickvergessen @irgendwie