Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix gender field select #825

Merged
merged 3 commits into from
Jan 9, 2019
Merged

fix gender field select #825

merged 3 commits into from
Jan 9, 2019

Conversation

hirschrobert
Copy link
Contributor

@hirschrobert hirschrobert commented Jan 5, 2019 •
edited by skjnldsv
Loading

see #780 , still to do: make X-WAB-GENDER print in VCARD as well for MS compatibility

Fix #780

@hirschrobert
fix gender field select
8565a79 
Signed-off-by: Robert Hirsch <info@robert-hirsch.de>
@skjnldsv skjnldsv self-requested a review January 6, 2019 00:19
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature labels Jan 6, 2019
@skjnldsv skjnldsv added this to the 3.0.2 milestone Jan 6, 2019
skjnldsv
skjnldsv requested changes Jan 8, 2019
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
We're missing a default value though. 😀

@skjnldsv
Use type for select and make sure default type is applied
ed793e4 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Fix default type
d7727d2 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit 11cbf84 into master Jan 9, 2019
@skjnldsv skjnldsv deleted the gender branch January 9, 2019 08:32
@skjnldsv skjnldsv restored the gender branch January 11, 2019 08:34
@skjnldsv skjnldsv mentioned this pull request Jan 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@hirschrobert @skjnldsv