Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically redirect if modRewriteWorking is supported #899

Merged
merged 2 commits into from
Feb 10, 2019
Merged

Automatically redirect if modRewriteWorking is supported #899

merged 2 commits into from
Feb 10, 2019

Conversation

skjnldsv
Copy link
Member

Fix #802

@skjnldsv
Automatically redirect if modRewriteWorking is supported
4e2b5af 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews labels Jan 30, 2019
@skjnldsv skjnldsv added this to the next milestone Jan 30, 2019
@skjnldsv skjnldsv self-assigned this Jan 30, 2019
@skjnldsv skjnldsv requested a review from weeman1337 January 30, 2019 15:45
@codecov
Copy link

codecov bot commented Jan 30, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@55bb0ba). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #899   +/-   ##
=========================================
  Coverage          ?   64.91%           
=========================================
  Files             ?        4           
  Lines             ?       57           
  Branches          ?        0           
=========================================
  Hits              ?       37           
  Misses            ?       20           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55bb0ba...08775c3. Read the comment docs.

@skjnldsv
Copy link
Member Author

skjnldsv commented Feb 4, 2019

Ping @weeman1337 😉

weeman1337
weeman1337 reviewed Feb 10, 2019
View reviewed changes
Copy link
Member

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✓ works

@skjnldsv skjnldsv merged commit 2e49720 into master Feb 10, 2019
@skjnldsv skjnldsv deleted the index-php-redirect branch February 10, 2019 16:06
@1ndahous3 1ndahous3 mentioned this pull request Mar 7, 2019
Closed
@skjnldsv skjnldsv modified the milestones: next, 3.0.4 Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weeman1337 weeman1337 weeman1337 approved these changes

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
3.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@skjnldsv @weeman1337