Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use virtual scroller for big contacts list display performances #1018

Merged
merged 2 commits into from
Mar 27, 2019

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 26, 2019

@fwolfst could you try this build? It should drastically improve the rendering and usability of the contacts list with lots of entries :)
contacts.tar.gz

@skjnldsv skjnldsv added 3. to review Waiting for reviews performance Performance issues and optimisations labels Mar 26, 2019
@skjnldsv skjnldsv added this to the next minor milestone Mar 26, 2019
@skjnldsv skjnldsv self-assigned this Mar 26, 2019
@fwolfst
Copy link

fwolfst commented Mar 26, 2019

Unfortunately I dont have a staging copy up yet and if I throw it in the production setup it wants me to run updates. I guess there is some trick to overcome it (fake the version number?). Or does it indeed need to run an update step due to the changed js-package dependencies? If so, I might not be able to do a quick test within the next dozens of hours - i unfortunately do not have an automatic staging setup-setup.

@codecov

This comment has been minimized.

@skjnldsv
Copy link
Member Author

Unfortunately I dont have a staging copy up yet and if I throw it in the production setup it wants me to run updates. I guess there is some trick to overcome it (fake the version number?). Or does it indeed need to run an update step due to the changed js-package dependencies? If so, I might not be able to do a quick test within the next dozens of hours - i unfortunately do not have an automatic staging setup-setup.

I indeed increased he version number to trigger a cache clear (harmless, but this is usually better to make sure cache issues are out of the way)
If this is a production instance and you're not the only one on it, I'd advise against testing it then.
If you're alone, it won't change anything nor trigger database changes. You can edit the appinfo/info.xml file and set it back to 3.0.5 if you don't want to trigger an update :)

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the enhancement/perf/virtual-scroller branch from 5d73385 to 606bcc1 Compare March 27, 2019 09:39
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the enhancement/perf/virtual-scroller branch from 606bcc1 to 201ed2a Compare March 27, 2019 09:44
@skjnldsv skjnldsv merged commit 2736326 into master Mar 27, 2019
@skjnldsv skjnldsv deleted the enhancement/perf/virtual-scroller branch March 27, 2019 10:06
@skjnldsv skjnldsv modified the milestones: next minor, 3.1.0 Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews performance Performance issues and optimisations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants