Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use displayname as file name when downloading a contact #1022

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

skjnldsv
Copy link
Member

fix #1019

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews labels Mar 28, 2019
@skjnldsv skjnldsv added this to the next milestone Mar 28, 2019
@skjnldsv skjnldsv self-assigned this Mar 28, 2019
@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #1022 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1022   +/-   ##
======================================
  Coverage      60%     60%           
======================================
  Files           4       4           
  Lines          60      60           
======================================
  Hits           36      36           
  Misses         24      24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa4dc2c...bb620d8. Read the comment docs.

@skjnldsv skjnldsv merged commit 73a315c into master Mar 28, 2019
@skjnldsv skjnldsv deleted the enhancement/download/vcf-filename branch March 28, 2019 12:42
@skjnldsv skjnldsv modified the milestones: next, 3.1.0 Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloaded .vcf Contact Files are Indecipherably Named
1 participant