-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing issue 1044 by letting the 'localContact' update #1049
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1049 +/- ##
======================================
Coverage 60% 60%
======================================
Files 4 4
Lines 60 60
======================================
Hits 36 36
Misses 24 24 Continue to review full report at Codecov.
|
Hello @rponline ! I'll do some reviewing of it today! 🎉 🤗 |
@@ -392,6 +392,7 @@ export default { | |||
this.fixed = false | |||
this.loadingUpdate = true | |||
await this.$store.dispatch('updateContact', this.localContact) | |||
this.updateLocalContact() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing this will erase any changes made during the firing of updateContact
and the updateLocalContact
. On small connexion this could cause some data loss. Like you're writing a note, and the update gets fired, but you keep writing. When the updateLocalContact
is reached, everything you kept writing will go back to the original state of the contact (not local) 🤔
I need to check if my theory is good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thx for the review! |
fix #1044