-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added possibility to show and edit vCard Geo attributes #1250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! :)
We could standardise a bit more! See comments! 🚀 👍
@tacruc so what do you think, good enough? |
08672be
to
3de0a41
Compare
Signed-off-by: Arne Hamann <kontakt+github@arne.email>
3de0a41
to
0b3bbdd
Compare
Codecov Report
@@ Coverage Diff @@
## master #1250 +/- ##
======================================
Coverage 60% 60%
======================================
Files 4 4
Lines 60 60
======================================
Hits 36 36
Misses 24 24 Continue to review full report at Codecov.
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Noticed it is called "location" super. However it asks for a URL? Checking a vcf export I see this:
If I read this: https://en.wikipedia.org/wiki/VCard If the export was V4 the parameter notation: VALUE=URI:geo:5.0000,52.0000 is to be used in other properties such as additional BIRTHPLACE or DEATHPLACE... Also the separating comma should not be escaped (preceded by ) I believe... |
Signed-off-by: Arne Hamann kontakt+github@arne.email