Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TZ & LANG #1264

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Add TZ & LANG #1264

merged 1 commit into from
Sep 27, 2019

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 14, 2019

Fix #1048

@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews labels Sep 14, 2019
@skjnldsv skjnldsv added this to the next milestone Sep 14, 2019
@skjnldsv skjnldsv requested a review from georgehrke September 14, 2019 22:30
@skjnldsv skjnldsv self-assigned this Sep 14, 2019
@codecov
Copy link

codecov bot commented Sep 14, 2019

Codecov Report

Merging #1264 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1264   +/-   ##
======================================
  Coverage      60%     60%           
======================================
  Files           4       4           
  Lines          60      60           
======================================
  Hits           36      36           
  Misses         24      24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6d17da...b593b3b. Read the comment docs.

@skjnldsv
Copy link
Member Author

Please review :D

@skjnldsv
Copy link
Member Author

ping !

@georgehrke
Copy link
Member

georgehrke commented Sep 20, 2019

My request to ask for TZ and LANG was a bit selfish, because i would like to use it for the calendar app. Whenever selecting a contact as an attendee, the invitation email should automatically use the contacts language and also show the time in the attendees' local timezone.

As i already mentioned at Nc conf, i would just offer the same list of languages we do in the server.
If we allow the user to enter a language, they will most likely enter stuff like "Deutsch" or "Français", which will be a tremendous pain for us to parse and map to the list of languages that we ship.

Offering that list of languages will provide a big advantage and i personally don't see the need to offer the user to enter every silly dialect that's spoken in whatever village with 5 people living there.

@skjnldsv
Copy link
Member Author

Okay :)
Shall I auto match the first prefix of a language tag?

If it's set to fr-ca-xx-xxx-x-x-x, I match with fr?
But if you change it would just set 'fr' !

@georgehrke
Copy link
Member

Sounds like a good plan to me :)

@skjnldsv
Copy link
Member Author

@tcitworld

This comment has been minimized.

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 20, 2019

I don't get your message @tcitworld :p

@skjnldsv
Copy link
Member Author

Done @georgehrke :)
I need to create a model for each rfc object so I can document and be a little more clean, but that will do for now!

associated matchings:

fr			=> fr
fr-fr		=> fr-fr
fr_fr		=> fr-fr
fr-fr-*		=> fr

@tcitworld
Copy link
Member

I don't get your message @tcitworld :p

My bad, didn't get a good look at the Transifex file.

@skjnldsv skjnldsv force-pushed the enhancement/tz-lang branch 4 times, most recently from e6a8124 to ad22d36 Compare September 26, 2019 19:15
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 27, 2019
@skjnldsv skjnldsv merged commit e303ca9 into master Sep 27, 2019
@skjnldsv skjnldsv deleted the enhancement/tz-lang branch September 27, 2019 06:29
@skjnldsv skjnldsv modified the milestones: next, 3.1.4 Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Timezone and Language
3 participants