Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement our own initialStateService for 15 #1291

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Oct 3, 2019

Fix #1287

@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews high High priority labels Oct 3, 2019
@skjnldsv skjnldsv self-assigned this Oct 3, 2019
@skjnldsv skjnldsv added this to the next milestone Oct 3, 2019
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #1291 into master will decrease coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1291      +/-   ##
==========================================
- Coverage    60.6%   60.31%   -0.29%     
==========================================
  Files           4        4              
  Lines          66       63       -3     
==========================================
- Hits           40       38       -2     
+ Misses         26       25       -1
Impacted Files Coverage Δ
lib/Controller/PageController.php 77.77% <100%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e9194c...a806e77. Read the comment docs.

@skjnldsv skjnldsv merged commit 8825d8c into master Oct 3, 2019
@skjnldsv skjnldsv deleted the fix/initialstate branch October 3, 2019 08:47
@skjnldsv skjnldsv modified the milestones: next, 3.1.5 Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working high High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot access Contacts 3.1.4 on Nextcloud 16 (Could not find initial state of contacts)
2 participants