Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing border in Contacts #159

Merged
merged 1 commit into from
Mar 9, 2017
Merged

Missing border in Contacts #159

merged 1 commit into from
Mar 9, 2017

Conversation

Dennis1993
Copy link
Contributor

I use your demo of NextCloud and founded a missing border. On the left is a grey border for the sidebar. On the next 2 divs is no border anymore. It would be good, if a border is here too to seperate it.

unbenannt-1

border missing in #eee on the second col (right side)
@MariusBluem MariusBluem added 3. to review Waiting for reviews design Related to the design labels Mar 9, 2017
@MariusBluem
Copy link
Member

Example Screenshot with your Fix:

bildschirmfoto 2017-03-09 um 20 15 56

Copy link
Member

@MariusBluem MariusBluem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍 Tested on Nextcloud's latest master with Safari and Chrome 👊 Thank you very much for your contribution.

@MariusBluem MariusBluem added this to the 1.5.4 milestone Mar 9, 2017
@irgendwie
Copy link
Member

Thank you! 👍

@Dennis1993
Copy link
Contributor Author

Thank you for your quick feedback!

@irgendwie irgendwie merged commit add39b0 into nextcloud:master Mar 9, 2017
@MariusBluem MariusBluem removed request for Henni and skjnldsv March 9, 2017 19:52
@jancborchardt
Copy link
Member

@Dennis1993 thanks for your contribution! :) It would be cool if you can fix it in the server too so it’s also applied to other apps which use this layout (like Mail https://github.com/nextcloud/mail)

You just need to add the code blocks .app-content-list (and all below starting with that) as well as .app-content-detail into this file: https://github.com/nextcloud/server/blob/master/core/css/apps.scss :)

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish design Related to the design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants