-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support X-PHONETIC-FIRST-NAME and X-PHONETIC-LAST-NAME #1741
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1741 +/- ##
=============================================
- Coverage 75.43% 40.05% -35.39%
- Complexity 13 128 +115
=============================================
Files 4 17 +13
Lines 57 377 +320
=============================================
+ Hits 43 151 +108
- Misses 14 226 +212
Continue to review full report at Codecov.
|
Signed-off-by: Tomohiro Masubuchi <bucchi79@gmail.com>
Signed-off-by: Tomohiro Masubuchi <bucchi79@gmail.com>
3e82509
to
59f23ed
Compare
This changes was pointed out int the review at https://github.com/nextcloud/contacts/pull/1741/files/59f23ed514cf7c653b779af8dc65e26ec221184e#r468369340 Signed-off-by: Tomohiro Masubuchi <bucchi79@gmail.com>
965c5d6
to
5609c3b
Compare
Signed-off-by: Tomohiro Masubuchi <bucchi79@gmail.com>
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Congrats!! |
Thank you for your helping! |
fix #251
I wrote the patch to support X-PHONETIC-FIRST-NAME and X-PHONETIC-LAST-NAME properties (issue #251) based on v3.3.0.
This patch changes two things:
In Japan, a phonetic (pronounce) name is one of the essential feature for address book.
Because, the Kanji character has many pronunciation.
So, usually contact list is sorted by phonetic order.
NOTE: The X-PHONETIC-FIRST-NAME and X-PHONETIC-LAST-NAME properties are
already normally supported on Android and iOS.
Could you review and merge my code?
Thanks!