vcard should only have 1 photo field when adding/removing photos #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when adding photo fields through the social api service, an extra photo field is created for vcard version 3.0 due to setting a field as empty instead of unsetting it all together when removing photo fields, this empty photo field is left untouched thus, syncing photos to address book clients can be buggy as most address book clients do not properly iterate through all photo fields to display the contact photo Signed-off-by: leith abdulla <online-nextcloud@eleith.com>
eleith
force-pushed
the
double-photo-fields
branch
from
f653a3c to
3d6bcd3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1918 +/- ##
============================================
+ Coverage 66.85% 67.43% +0.57%
Complexity 249 249
============================================
Files 22 22
Lines 691 691
============================================
+ Hits 462 466 +4
+ Misses 229 225 -4
Continue to review full report at Codecov.
|
skjnldsv
approved these changes
Nov 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when adding photo fields through the social api service, an extra photo
field is created for vcard version 3.0 due to setting a field as empty
instead of unsetting it all together
when removing photo fields, this empty photo field is left untouched
thus, syncing photos to address book clients can be buggy as most
address book clients do not properly iterate through all photo fields to
display the contact photo
closes: #1820