Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Workaround for Postal Addresses Containing Commas #2000

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

zlajo
Copy link
Contributor

@zlajo zlajo commented Dec 30, 2020

It seems like the base issue #386 on ical.js has been fixed. Because of that the workaround should be removed as well.

@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #2000 (0a4e98c) into master (e7dfd07) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2000   +/-   ##
========================================
  Coverage      0.00%   0.00%           
  Complexity      249     249           
========================================
  Files            22      22           
  Lines           738     738           
========================================
  Misses          738     738           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7dfd07...be4d5fc. Read the comment docs.

@skjnldsv skjnldsv merged commit ada212c into nextcloud:master Jan 4, 2021
@welcome
Copy link

welcome bot commented Jan 4, 2021

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-contacts and #nextcloud-dev on Freenode for a chat!

@skjnldsv skjnldsv added bug Something isn't working 4. to release Ready to be released and/or waiting for tests to finish labels Jan 4, 2021
@zlajo zlajo deleted the remove_vcard_label_workaround branch January 4, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants