Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure twitter returns the raw static html page so we can get the … #2013

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

skjnldsv
Copy link
Member

Fix #2012

Also fix addressbook decode if there is a space in it or any special char

@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature labels Jan 11, 2021
@skjnldsv skjnldsv added this to the next milestone Jan 11, 2021
@skjnldsv skjnldsv requested a review from call-me-matt January 11, 2021 11:32
@skjnldsv skjnldsv self-assigned this Jan 11, 2021
…profile picture properly

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #2013 (42f82bd) into master (7646cbf) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2013   +/-   ##
========================================
  Coverage      0.00%   0.00%           
  Complexity      249     249           
========================================
  Files            22      22           
  Lines           738     748   +10     
========================================
- Misses          738     748   +10     
Impacted Files Coverage Δ Complexity Δ
lib/Service/Social/TwitterProvider.php 0.00% <0.00%> (ø) 17.00 <1.00> (ø)
lib/Service/SocialApiService.php 0.00% <0.00%> (ø) 55.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7646cbf...bf48bcd. Read the comment docs.

Copy link
Member

@call-me-matt call-me-matt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thank you for finding, debugging and fixing this 👍

@skjnldsv skjnldsv merged commit 4bd46d6 into master Jan 12, 2021
@skjnldsv skjnldsv deleted the fix/twitter-grep branch January 12, 2021 07:06
@skjnldsv skjnldsv removed this from the next milestone Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twitter Profile Images Not Scraped
2 participants