Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate app bootstrapping #2364

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Migrate app bootstrapping #2364

merged 1 commit into from
Jul 30, 2021

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jul 21, 2021

Todo

Test plan

  • Open files app: Use contact integration on the upper right
  • Create contact
  • Update contact
  • Delete contact
  • Contact: Download
  • Contact: Import
  • Contact: Generate QR code
  • Create group and add a member
  • Delete group (=> unset the group for each member)
  • Group: Download
  • Group: Import
  • Create address book
  • Delete address book
  • Rename address book
  • Address book: Download

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #2364 (c678bf9) into master (292e356) will not change coverage.
The diff coverage is 0.00%.

❗ Current head c678bf9 differs from pull request most recent head 42a1706. Consider uploading reports for the commit 42a1706 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2364   +/-   ##
=========================================
  Coverage     69.25%   69.25%           
- Complexity      246      247    +1     
=========================================
  Files            22       21    -1     
  Lines           696      696           
=========================================
  Hits            482      482           
  Misses          214      214           
Impacted Files Coverage Δ
lib/AppInfo/Application.php 0.00% <0.00%> (ø)
lib/Dav/PatchPlugin.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 292e356...42a1706. Read the comment docs.

@skjnldsv skjnldsv added 3. to review Waiting for reviews enhancement New feature or request technical debt labels Jul 21, 2021
@kesselb kesselb added 2. developing Work in progress and removed enhancement New feature or request 3. to review Waiting for reviews labels Jul 21, 2021
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the enh/1831/bye-bye-app.php branch from c678bf9 to 42a1706 Compare July 21, 2021 17:21
@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 27, 2021
@kesselb
Copy link
Contributor Author

kesselb commented Jul 27, 2021

Contact: Generate QR code

I see a QR code ;) But don't know what tool/app could read it ...

@skjnldsv
Copy link
Member

I see a QR code ;) But don't know what tool/app could read it ...

Any qrcode reading app 😁

@kesselb
Copy link
Contributor Author

kesselb commented Jul 28, 2021

I see a QR code ;) But don't know what tool/app could read it ...

Any qrcode reading app grin

Thanks ;) I did another test with a different qr reader and it works 😎

@kesselb
Copy link
Contributor Author

kesselb commented Jul 28, 2021

Group: Download

Is broken (also on master): #2345

@kesselb
Copy link
Contributor Author

kesselb commented Jul 28, 2021

Group: Import

Tricky to test: Create an address book, Add a contact, Add a group for the contact, Export the address book, Delete the address book. Reload the page. Import the vcf. Now contact and group should be back.

@skjnldsv skjnldsv merged commit 79ef8b4 into master Jul 30, 2021
@welcome
Copy link

welcome bot commented Jul 30, 2021

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-contacts and #nextcloud-dev on Freenode for a chat!

@skjnldsv skjnldsv deleted the enh/1831/bye-bye-app.php branch July 30, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants