Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add organization charts #2954

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Add organization charts #2954

merged 1 commit into from
Sep 22, 2022

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Sep 22, 2022

Updated and continued version of #2726

@ChristophWurst ChristophWurst added enhancement New feature or request 2. developing Work in progress labels Sep 22, 2022
@ChristophWurst ChristophWurst added this to the v5.0 milestone Sep 22, 2022
@ChristophWurst ChristophWurst self-assigned this Sep 22, 2022
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 31.65% // Head: 67.96% // Increases project coverage by +36.30% 🎉

Coverage data is based on head (1f7140a) compared to base (503b84e).
Patch has no changes to coverable lines.

❗ Current head 1f7140a differs from pull request most recent head 9038e7d. Consider uploading reports for the commit 9038e7d to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2954       +/-   ##
=============================================
+ Coverage     31.65%   67.96%   +36.30%     
  Complexity      253      253               
=============================================
  Files           104       23       -81     
  Lines          1832      721     -1111     
  Branches        211        0      -211     
=============================================
- Hits            580      490       -90     
+ Misses         1141      231      -910     
+ Partials        111        0      -111     
Impacted Files Coverage Δ
src/components/AppContent/ContactsContent.vue
src/components/AppNavigation/RootNavigation.vue
src/components/ContactDetails.vue
...onents/ContactDetails/ContactDetailsAddNewProp.vue
...mponents/ContactDetails/ContactDetailsProperty.vue
src/components/Properties/PropertySelect.vue
src/models/contact.js
src/models/rfcProps.js
src/router/index.js
src/views/Contacts.vue
... and 71 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Co-Authored-By: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Vassilis Kritharakis <bkrith@hotmail.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 22, 2022
@ChristophWurst ChristophWurst marked this pull request as ready for review September 22, 2022 16:08
@ChristophWurst ChristophWurst mentioned this pull request Sep 22, 2022
23 tasks
@GretaD
Copy link
Contributor

GretaD commented Sep 22, 2022

looks good, i noticed just this small "down/up arrow" that is cut a bit
Screenshot from 2022-09-22 19-04-20

Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small comment, otherwise good

@ChristophWurst ChristophWurst merged commit 642a922 into main Sep 22, 2022
@ChristophWurst ChristophWurst deleted the feature/orgChart branch September 22, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

3 participants