Skip to content

Read-only addressbook improvements #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 8, 2017
Merged

Read-only addressbook improvements #299

merged 7 commits into from
Sep 8, 2017

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 25, 2017

  • Remove addressbook from the move select
  • Remove addressbook from the import select
  • Disable import if the only addressbook available is in read-only mode
  • Create read-only view for contacts in read-only addressbooks, fix Create a read-only view of a contact #294

@skjnldsv skjnldsv added 2. developing Work in progress bug Something isn't working medium Medium priority labels Aug 25, 2017
@skjnldsv skjnldsv added this to the 2.1.0 milestone Aug 25, 2017
@skjnldsv skjnldsv self-assigned this Aug 25, 2017
@codecov
Copy link

codecov bot commented Aug 25, 2017

Codecov Report

Merging #299 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #299   +/-   ##
=======================================
  Coverage   14.38%   14.38%           
=======================================
  Files          55       55           
  Lines        1251     1251           
=======================================
  Hits          180      180           
  Misses       1071     1071

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adfe23e...b9e0f2e. Read the comment docs.

@skjnldsv skjnldsv modified the milestones: 2.0.0, 2.1.0 Aug 25, 2017
@skjnldsv
Copy link
Member Author

This is done on purpose since the read only details page for those type of user will completely remove this dropdown :)

kazam_screenshot_00000

@skjnldsv skjnldsv force-pushed the ro-ab-improvement branch 2 times, most recently from 5b2c66c to 4a9349c Compare August 31, 2017 14:12
@skjnldsv
Copy link
Member Author

Hum, 1d1ccda broke the import

@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 31, 2017

Added readOnly details
contacts nextcloud
contacts nextcloud 1

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 1, 2017
Copy link
Member

@irgendwie irgendwie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 'Detailed name' is editable for me in read-only view
  • 'Gender' is not displayed in read-only mode

Edit: The only thing that bugs me is the two sets of templates...

@irgendwie irgendwie added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 3, 2017
@skjnldsv skjnldsv dismissed irgendwie’s stale review September 3, 2017 14:02

Fixed! Don't know why I missed these! ¯_(ツ)_/¯

@skjnldsv skjnldsv requested a review from irgendwie September 3, 2017 14:02
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 3, 2017
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@Henni
Copy link
Member

Henni commented Sep 3, 2017

I'm a bit late to the party, but why did you create a separate readonly template for every existing template?
Couldn't we simply integrate this into the existing templates?

Something like:

<input [...] ng-disabled="ctrl.addressBook.readOnly">

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 4, 2017

Tried that already, didn't liked the idea since a user can manually edit the field to remove the disabled state. But yes, I can push those commit if you prefer. I kind of like not having two templates too. :)

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 4, 2017

@Henni @irgendwie Done! Switch to previous commits.
Works fine too now! :)

Copy link
Member

@jonatoni jonatoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @skjnldsv 👍

@skjnldsv skjnldsv merged commit 119d409 into master Sep 8, 2017
@skjnldsv skjnldsv deleted the ro-ab-improvement branch September 8, 2017 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working medium Medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a read-only view of a contact
5 participants