Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update selectInput to select on "Name" #3635

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

cwerstuik
Copy link
Contributor

The default fullname for new contacts was changed to "Name" in 1505b81 but wasn't updated in the selectInput. This selects the fullname input on "Name" now.

P.S. This is my first ever pull request on Github so I apologize if I'm doing anything wrong.

Signed-off-by: Curtis Werstuik <geekatron101@gmail.com>
@cwerstuik
Copy link
Contributor Author

Hey @ChristophWurst and @st3iny I'm not able to add reviewers or labels and I noticed you've reviewed other pull requests here so just wanted to make sure this didn't get missed. Let me know if there are any other steps I need to take to get this merged. Thanks!

@st3iny st3iny self-requested a review October 17, 2023 12:09
@st3iny st3iny added 3. to review Waiting for reviews bug Something isn't working labels Oct 17, 2023
@st3iny st3iny added this to the v5.5.0 milestone Oct 17, 2023
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

Thank you very much :)

@st3iny
Copy link
Member

st3iny commented Oct 17, 2023

/backport to stable5.4

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a6c0a1f) 2.07% compared to head (0aa8f49) 2.07%.
Report is 23 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3635   +/-   ##
=====================================
  Coverage   2.07%   2.07%           
=====================================
  Files         89      89           
  Lines       5348    5348           
  Branches    1491    1491           
=====================================
  Hits         111     111           
  Misses      5119    5119           
  Partials     118     118           
Files Coverage Δ
src/components/ContactDetails.vue 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny merged commit bd5fbb9 into nextcloud:main Oct 17, 2023
24 of 25 checks passed
@welcome
Copy link

welcome bot commented Oct 17, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants