Add support for php8.3 #3642
Merged
Add support for php8.3 #3642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3642 +/- ##
==========================================
+ Coverage 1.81% 2.07% +0.26%
==========================================
Files 113 89 -24
Lines 6130 5348 -782
Branches 1491 1491
==========================================
Hits 111 111
+ Misses 5901 5119 -782
Partials 118 118 ☔ View full report in Codecov by Sentry. |
hamza221
force-pushed
the
feat/php8.3-support
branch
from
a6fd7bf to
a682f13
Compare
.github/workflows/phpunit.yml
Outdated
| @@ -88,7 +88,7 @@ jobs: | |||
| # do not stop on another job's failure | |||
| fail-fast: false | |||
| matrix: | |||
| php-versions: ['8.0', '8.1', '8.2'] | |||
| php-versions: ['8.0', '8.1', '8.2', '8.3'] | |||
There was a problem hiding this comment.
works, but bloats the matrix. could you move 8.0 out of this array and have one dedicated job in the include section below?
Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
hamza221
force-pushed
the
feat/php8.3-support
branch
from
a682f13 to
91d2cb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3641