Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reorder tel options #3652

Closed
wants to merge 1 commit into from
Closed

fix: reorder tel options #3652

wants to merge 1 commit into from

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Oct 10, 2023

Fix #3651, Close #3653

TYPE=VOICE does not work when defined after TYPE=HOME,VOICE due a weakness in the matching.

Downside:

  • Changing the order here also changes the order in the select.
  • It does not address the weakness in the matching.
This PR Main
Screenshot from 2023-10-10 20-16-56 Screenshot from 2023-10-10 20-18-12
Screenshot from 2023-10-10 20-15-16 Screenshot from 2023-10-10 20-18-23

TYPE=VOICE does not work when defined after TYPE=HOME,VOICE due a weakness in the matching algorithm.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb self-assigned this Oct 10, 2023
@kesselb kesselb added bug Something isn't working 3. to review Waiting for reviews labels Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9854dd8) 2.07% compared to head (6afd151) 0.00%.

❗ Current head 6afd151 differs from pull request most recent head 53b0f69. Consider uploading reports for the commit 53b0f69 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              main   #3652      +/-   ##
==========================================
- Coverage     2.07%   0.00%   -2.08%     
- Complexity       0     260     +260     
==========================================
  Files           89      24      -65     
  Lines         5348     782    -4566     
  Branches      1491       0    -1491     
==========================================
- Hits           111       0     -111     
+ Misses        5119     782    -4337     
+ Partials       118       0     -118     

see 113 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny closed this in #3653 Oct 11, 2023
@st3iny st3iny deleted the bug/3651/reorder-rfc-props branch October 11, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tel property with type Voice don't work
1 participant