Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable5.4] fix: improve matching for tel type parameter #3655

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #3653

The old implementation assigns the same score for HOME,VOICE and VOICE for a tel property with parameter voice.

This pull requests adds an aditional point for the items with the same length.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@backportbot-nextcloud backportbot-nextcloud bot added the bug Something isn't working label Oct 11, 2023
@backportbot-nextcloud backportbot-nextcloud bot added this to the v5.4.0 milestone Oct 11, 2023
@st3iny st3iny modified the milestones: v5.4.0, v5.4.3 Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (894c11c) 0.00% compared to head (664761a) 0.00%.

❗ Current head 664761a differs from pull request most recent head 912ac3a. Consider uploading reports for the commit 912ac3a to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             stable5.4   #3655    +/-   ##
============================================
  Coverage             0   0.00%            
- Complexity           0     260   +260     
============================================
  Files                0      24    +24     
  Lines                0     782   +782     
============================================
- Misses               0     782   +782     

see 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@st3iny st3iny merged commit bb749ca into stable5.4 Oct 11, 2023
26 checks passed
@st3iny st3iny deleted the backport/3653/stable5.4 branch October 11, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants