Add shared items and events for each contact

[GretaD]

fixes #3364

• Requires Add the resource type on RelatedResourcesPanel nextcloud-libraries/nextcloud-vue#4662
• Requires Contacts provider related_resources#302 and new API param resourceType related_resources#303
• documentation Document shared items feature for contacts documentation#11270
• required Upgrade to Nextcloud vue 8.0.0 #3695

[codecov]

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (49e252d) 1.80% compared to head (43de764) 2.06%.

Additional details and impacted files

@@            Coverage Diff             @@
##              main   #3670      +/-   ##
==========================================
+ Coverage     1.80%   2.06%   +0.25%     
==========================================
  Files          113      89      -24     
  Lines         6133    5379     -754     
  Branches      1505    1523      +18     
==========================================
  Hits           111     111              
+ Misses        5901    5147     -754     
  Partials       121     121              

Files	Coverage Δ
src/components/ContactDetails.vue	0.00% <0.00%> (ø)

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[GretaD]

Big screen view. Looks like this. I will make the spaces between app shares smaller. But otherwise, will look like this.

Im not sure if we should show them on small screen, but this is the only acceptable view i can think of. I would say on small screen, not to show related resources with the argument that we already have quick actions and thats enough, but this is not my decision to make.

@nimishavijay now you can review it and let me know what do you think can be improved :)

[ChristophWurst]

The Anything shared with the same group of people … is strange for events shared with this contact IMO. If this is coming from nc/vue, we might want to add an option to hide or replace the text.

[nimishavijay]

Super nice! It looks great :)

Anything shared with the same group of people … is strange for events shared with this contact

I agree with this, in fact I would say we don't even need a subline if we name the headings appropriately.

• So "Media shares" --> "Recently shared items"
• "Talk conversations" is already informative enough, so that doesn't need a subline either

Some more feedback/questions:

• What is the font size of the heading? I may be wrong but it seems a bit smaller than the body text. It should be the same size
• How many items are shown for each section? We can limit it to 5 most recently changed
• Is it possible to show a thumbnail for the shared files/photos?
• Is it possible to show the conversation picture for the Talk conversations?

For smaller screens, I would agree with your placement in the screenshot, below the rest of the contact info. Since people use contacts apps on their phones a lot I would not remove it completely, but it can go at the bottom :)

[nimishavijay]

Feedback from the rest of the team:

• "Recently shared items" --> "Media shared with you"
• "Talk conversations" --> "Talk conversations together"

cc @jancborchardt :)

@GretaD it would be great if the previews could make it in as they are a pretty important part of this feature. If there is something much more urgent on your todo list then all good, but otherwise the previews would be great to have :)

[st3iny]

Tested and works so far.

There are some design issues:

• The related resource panel does not wrap to the right column. It is rendered below the contacts form.
• Panels with errors should be hidden. They emit an event @has-error which could be leveraged to achieve this. The state of each panel could be saved to a boolean and then the panel could be hidden via v-if if the error is true for a given panel.

[GretaD]

Feedback from the rest of the team:

• "Recently shared items" --> "Media shared with you"
• "Talk conversations" --> "Talk conversations together"

There are 2 more apps, calendar and decks. What header do you propose there? Right now is Calendar events and Deck cards.

cc @jancborchardt :)

@GretaD it would be great if the previews could make it in as they are a pretty important part of this feature. If there is something much more urgent on your todo list then all good, but otherwise the previews would be great to have :)

If the related resource changes to support preview and the changes we need on the nc/vue are merged and tested today, i can try and make it work for tomorrow(deadline), but this needs some work in different apps and libraries and we might not have the time to do it perfectly and not easily breakable design wise.

[jancborchardt]

@GretaD @nimishavijay maybe to simplify, we can go with "[…] with you" for all headings? So:

• Media shares with you
• Talk conversations with you
• Calendar events with you
• Deck cards with you

And no subline. Then it's clear it's things you have in common, in clear language. (Otherwise it sounded like you can see their shares.)

[GretaD]

Tested and works so far.

There are some design issues:

• The related resource panel does not wrap to the right column. It is rendered below the contacts form.

I think this was caused by the error message, because it was too long and not wrapped. Now we hide it when the app is not activated, so the screen will break when the screen is smaller than 1600px wide.

[st3iny]

Tested and works. My previous review was addressed.

Unfortunately, we can only merge this after updating nc-vue to 8 :(