Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the empty content showing on edit mode #3702

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Nov 14, 2023

Screenshot from 2023-11-14 14-15-29
after Screenshot from 2023-11-14 14-17-24

this pr fixes

  • the empty content shown before the contact details are loaded
  • the empty content shown on edit mode
  • desc is not required

Signed-off-by: greta <gretadoci@gmail.com>
@GretaD GretaD added the 3. to review Waiting for reviews label Nov 14, 2023
@GretaD GretaD self-assigned this Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ee3730b) 2.06% compared to head (28a3d81) 2.06%.
Report is 7 commits behind head on main.

Files Patch % Lines
src/components/ContactDetails.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3702   +/-   ##
=====================================
  Coverage   2.06%   2.06%           
=====================================
  Files         89      89           
  Lines       5379    5379           
  Branches    1523    1523           
=====================================
  Hits         111     111           
  Misses      5147    5147           
  Partials     121     121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GretaD GretaD merged commit 5a12cef into main Nov 14, 2023
26 of 27 checks passed
@GretaD GretaD deleted the fix/edit-mode-related-resources branch November 14, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants