Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): Add Nextcloud 29 support #3715

Merged
merged 1 commit into from
Nov 23, 2023
Merged

feat(deps): Add Nextcloud 29 support #3715

merged 1 commit into from
Nov 23, 2023

Conversation

nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling coding@schilljs.com

@hamza221
Copy link
Contributor

We're on rc1 #3714

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d0222ee) 2.06% compared to head (cd6b367) 2.06%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3715   +/-   ##
=====================================
  Coverage   2.06%   2.06%           
=====================================
  Files         89      89           
  Lines       5379    5379           
  Branches    1523    1523           
=====================================
  Hits         111     111           
  Misses      5147    5147           
  Partials     121     121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not drop 25 in here right before branching off. Let's drop 25 for the next minor of Contacts only

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong radio

@ChristophWurst
Copy link
Member

all previous pre-releases supported 25 so I would keep this until the final

Signed-off-by: Joas Schilling <coding@schilljs.com>
@hamza221 hamza221 force-pushed the update-main-version branch from fd90c6e to cd6b367 Compare November 23, 2023 14:49
@hamza221 hamza221 enabled auto-merge November 23, 2023 15:28
@hamza221 hamza221 merged commit ac06fcb into main Nov 23, 2023
27 checks passed
@hamza221 hamza221 deleted the update-main-version branch November 23, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants