Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: share address books with user groups #4291

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix: share address books with user groups #4291

merged 1 commit into from
Jan 9, 2025

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Jan 9, 2025

fix #4203

@hamza221
fix: share address books with user groups
6e87aca 
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature labels Jan 9, 2025
@hamza221 hamza221 requested a review from st3iny January 9, 2025 15:04
@hamza221 hamza221 self-assigned this Jan 9, 2025
@hamza221 hamza221 requested a review from GVodyanov as a code owner January 9, 2025 15:04
@hamza221
Copy link
Contributor Author

hamza221 commented Jan 9, 2025

/backport to stable6.0

@hamza221
Copy link
Contributor Author

hamza221 commented Jan 9, 2025

/backport to stable6.1

@hamza221 hamza221 merged commit d0b43eb into main Jan 9, 2025
32 checks passed
@hamza221 hamza221 deleted the fix/share-groups branch January 9, 2025 15:19
This was referenced Jan 9, 2025
Merged
Merged
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 11.15%. Comparing base (714a93d) to head (6e87aca).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ppNavigation/Settings/SettingsAddressbookShare.vue 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #4291   +/-   ##
=========================================
  Coverage     11.15%   11.15%           
  Complexity      265      265           
=========================================
  Files           121      121           
  Lines          5533     5533           
  Branches       1196     1196           
=========================================
  Hits            617      617           
- Misses         4794     4795    +1     
+ Partials        122      121    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GretaD GretaD GretaD approved these changes

@st3iny st3iny Awaiting requested review from st3iny

@GVodyanov GVodyanov Awaiting requested review from GVodyanov GVodyanov is a code owner

Assignees

@hamza221 hamza221

Labels
3. to review Waiting for reviews bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User Groups not shown as a option when sharing an address book
2 participants
@hamza221 @GretaD