Skip to content

fix: use untranslated category for grouping contacts #4664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kesselb merged 1 commit into from
Oct 7, 2025
Merged

fix: use untranslated category for grouping contacts #4664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/AppNavigation/RootNavigation.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
<AppNavigationItem
v-if="isContactsInteractionEnabled && recentlyContactedContacts && recentlyContactedContacts.contacts.length > 0"
id="recentlycontacted"
:name="GROUP_RECENTLY_CONTACTED"
:name="t('contacts', 'Recently contacted')"
:to="{
name: 'group',
params: { selectedGroup: GROUP_RECENTLY_CONTACTED },
Expand Down Expand Up @@ -243,10 +243,10 @@
props: {
loading: {
type: Boolean,
default: true,

Check warning on line 246 in src/components/AppNavigation/RootNavigation.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Boolean prop should only be defaulted to false
},

contactsList: {

Check warning on line 249 in src/components/AppNavigation/RootNavigation.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

'contactsList' of property found, but never used
type: Array,
required: true,
},
Expand Down
2 changes: 1 addition & 1 deletion src/models/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export const LIST_SIZE = 60
// Dynamic default groups
export const GROUP_ALL_CONTACTS: DefaultGroup = t('contacts', 'All contacts')
export const GROUP_NO_GROUP_CONTACTS: DefaultGroup = t('contacts', 'Not grouped')
export const GROUP_RECENTLY_CONTACTED: DefaultGroup = t('contacts', 'Recently contacted')
export const GROUP_RECENTLY_CONTACTED: DefaultGroup = 'Recently contacted'

// Organization default chart for all contacts
export const CHART_ALL_CONTACTS: DefaultChart = t('contacts', 'Organization chart')
Expand Down
Loading