Skip to content

[stable8.0] fix: use untranslated category for grouping contacts#4771

Merged
hamza221 merged 1 commit intostable8.0from
backport/4664/stable8.0
Oct 7, 2025
Merged

[stable8.0] fix: use untranslated category for grouping contacts#4771
hamza221 merged 1 commit intostable8.0from
backport/4664/stable8.0

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Oct 7, 2025

Backport of PR #4664

@backportbot backportbot bot requested a review from hamza221 as a code owner October 7, 2025 17:33
@backportbot backportbot bot requested a review from hamza221 October 7, 2025 17:33
@backportbot backportbot bot requested a review from GVodyanov as a code owner October 7, 2025 17:33
@backportbot backportbot bot requested a review from kesselb October 7, 2025 17:34
@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews labels Oct 7, 2025
@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 9.70%. Comparing base (caa947c) to head (dd259d6).
⚠️ Report is 2 commits behind head on stable8.0.

Additional details and impacted files
@@             Coverage Diff             @@
##             stable8.0   #4771   +/-   ##
===========================================
  Coverage         9.70%   9.70%           
  Complexity         266     266           
===========================================
  Files              124     124           
  Lines             6336    6336           
  Branches          1189    1189           
===========================================
  Hits               615     615           
  Misses            5599    5599           
  Partials           122     122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hamza221
Copy link
Contributor

hamza221 commented Oct 7, 2025

Contacts Ci is not behaving lately, a fix is coming in a few seconds, I'll rebase

The grouping in contacts is done by the categories attribute. The cards
created for recently contacted are using a translated string for the
category. This leads to a weird state when a user switched languages
inbetween.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@hamza221 hamza221 force-pushed the backport/4664/stable8.0 branch from 1081544 to dd259d6 Compare October 7, 2025 17:55
@hamza221 hamza221 merged commit 30660dd into stable8.0 Oct 7, 2025
34 checks passed
@hamza221 hamza221 deleted the backport/4664/stable8.0 branch October 7, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants