[stable8.0] fix: use untranslated category for grouping contacts#4771
Merged
[stable8.0] fix: use untranslated category for grouping contacts#4771
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stable8.0 #4771 +/- ##
===========================================
Coverage 9.70% 9.70%
Complexity 266 266
===========================================
Files 124 124
Lines 6336 6336
Branches 1189 1189
===========================================
Hits 615 615
Misses 5599 5599
Partials 122 122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kesselb
approved these changes
Oct 7, 2025
Contributor
|
Contacts Ci is not behaving lately, a fix is coming in a few seconds, I'll rebase |
The grouping in contacts is done by the categories attribute. The cards created for recently contacted are using a translated string for the category. This leads to a weird state when a user switched languages inbetween. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
1081544 to
dd259d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #4664