Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ABLABEL and ITEMX.property support #991

Merged
merged 7 commits into from
Mar 29, 2019
Merged

Add ABLABEL and ITEMX.property support #991

merged 7 commits into from
Mar 29, 2019

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 12, 2019 •
edited
Loading

Fix #42
Fix #27

Please help reviewing:
contacts.tar.gz

@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews labels Mar 12, 2019
@skjnldsv skjnldsv added this to the next minor milestone Mar 12, 2019
@skjnldsv skjnldsv self-assigned this Mar 12, 2019
@skjnldsv skjnldsv force-pushed the enhancement/ablabel branch from a282083 to 9f43ea1 Compare March 12, 2019 09:04
@skjnldsv skjnldsv mentioned this pull request Mar 12, 2019
Closed
@codecov
Copy link

codecov bot commented Mar 12, 2019 •
edited
Loading

Codecov Report

Merging #991 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #991   +/-   ##
=====================================
  Coverage      60%    60%           
=====================================
  Files           4      4           
  Lines          60     60           
=====================================
  Hits           36     36           
  Misses         24     24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae80cf1...1fb881b. Read the comment docs.

@skjnldsv skjnldsv force-pushed the enhancement/ablabel branch 2 times, most recently from c959949 to 14b940e Compare March 27, 2019 18:40
@skjnldsv
Add ABLABEL and ITEMX.property support
f67a5cc 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the enhancement/ablabel branch from 14b940e to f67a5cc Compare March 27, 2019 18:42
skjnldsv added 2 commits March 27, 2019 22:27
@skjnldsv
Properly save and update existing custom labels
8565139 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Support ABLABEL custom labels
e4bf88c 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2019
Closed
skjnldsv added 4 commits March 28, 2019 14:00
@skjnldsv
Properly sort grouped props
a20695d 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Properly group grouper properties
5cfe270 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Properly display custom long labels
177c5be 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Fix mobile select alignment
1fb881b 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit 0444744 into master Mar 29, 2019
@skjnldsv skjnldsv deleted the enhancement/ablabel branch March 29, 2019 07:05
@skjnldsv skjnldsv modified the milestones: next minor, 3.1.0 Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@skjnldsv