Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use Taskprocessing TextToText provider as LLM #60

Merged
merged 12 commits into from
Jul 29, 2024

Conversation

marcelklehr
Copy link
Member

No description provided.

@marcelklehr marcelklehr force-pushed the feat/taskprocessing-llm branch from 88bfc8f to 0024e39 Compare July 22, 2024 07:48
@marcelklehr marcelklehr force-pushed the feat/taskprocessing-llm branch from af92dfe to 78cd111 Compare July 22, 2024 08:30
@marcelklehr marcelklehr marked this pull request as ready for review July 23, 2024 11:41
@marcelklehr
Copy link
Member Author

We should probably also remove the free prompt provider from context_chat then as it will loop otherwise

@kyteinsky
Copy link
Contributor

kyteinsky commented Jul 23, 2024

We should probably also remove the free prompt provider from context_chat then as it will loop otherwise

good idea

nextcloud/context_chat#50

kyteinsky added a commit to nextcloud/context_chat that referenced this pull request Jul 23, 2024
to prevent looping due to the backend using the task processing text2text
provider for llm tasks
(nextcloud/context_chat_backend#60)

Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
@kyteinsky
Copy link
Contributor

looks good save the above reviews! There are some format and lint issues. Please install the dev tools from requirements.dev.txt to hunt them down.

@marcelklehr marcelklehr force-pushed the feat/taskprocessing-llm branch 2 times, most recently from edff160 to 15041b4 Compare July 25, 2024 07:25
@marcelklehr marcelklehr requested a review from kyteinsky July 25, 2024 07:29
@kyteinsky
Copy link
Contributor

would be nice to drop stable28 and 29 integration tests due to context chat app's incompatibility

@marcelklehr
Copy link
Member Author

Yep, fixing the integration test atm

@marcelklehr marcelklehr force-pushed the feat/taskprocessing-llm branch from d40c485 to 9a051f7 Compare July 25, 2024 07:39
@marcelklehr
Copy link
Member Author

mmmh

{"reqId":"xGeoX3DkV3P2q7LGrJhw","level":3,"time":"2024-07-25T10:29:35+00:00","remoteAddr":"","user":"--","app":"core","method":"","url":"--","message":"Error while running background job OC\\TaskProcessing\\SynchronousBackgroundJob (id: 35, arguments: null)","userAgent":"--","version":"30.0.0.2","exception":{"Exception":"JsonException","Message":"Malformed UTF-8 characters, possibly incorrectly encoded","Code":5,"Trace":[{"file":"/home/runner/work/context_chat_backend/context_chat_backend/lib/private/TaskProcessing/Db/Task.php","line":113,"function":"json_encode"},{"file":"/home/runner/work/context_chat_backend/context_chat_backend/lib/private/TaskProcessing/Manager.php","line":884,"function":"fromPublicTask","class":"OC\\TaskProcessing\\Db\\Task","type":"::"},{"file":"/home/runner/work/context_chat_backend/context_chat_backend/lib/private/TaskProcessing/SynchronousBackgroundJob.php","line":81,"function":"setTaskResult","class":"OC\\TaskProcessing\\Manager","type":"->"},{"file":"/home/runner/work/context_chat_backend/context_chat_backend/lib/public/BackgroundJob/Job.php","line":61,"function":"run","class":"OC\\TaskProcessing\\SynchronousBackgroundJob","type":"->"},{"file":"/home/runner/work/context_chat_backend/context_chat_backend/lib/public/BackgroundJob/QueuedJob.php","line":43,"function":"start","class":"OCP\\BackgroundJob\\Job","type":"->"},{"file":"/home/runner/work/context_chat_backend/context_chat_backend/lib/public/BackgroundJob/QueuedJob.php","line":29,"function":"start","class":"OCP\\BackgroundJob\\QueuedJob","type":"->"},{"file":"/home/runner/work/context_chat_backend/context_chat_backend/core/Command/Background/JobWorker.php","line":109,"function":"execute","class":"OCP\\BackgroundJob\\QueuedJob","type":"->"},{"file":"/home/runner/work/context_chat_backend/context_chat_backend/3rdparty/symfony/console/Command/Command.php","line":298,"function":"execute","class":"OC\\Core\\Command\\Background\\JobWorker","type":"->"},{"file":"/home/runner/work/context_chat_backend/context_chat_backend/core/Command/Base.php","line":159,"function":"run","class":"Symfony\\Component\\Console\\Command\\Command","type":"->"},{"file":"/home/runner/work/context_chat_backend/context_chat_backend/3rdparty/symfony/console/Application.php","line":1040,"function":"run","class":"OC\\Core\\Command\\Base","type":"->"},{"file":"/home/runner/work/context_chat_backend/context_chat_backend/3rdparty/symfony/console/Application.php","line":301,"function":"doRunCommand","class":"Symfony\\Component\\Console\\Application","type":"->"},{"file":"/home/runner/work/context_chat_backend/context_chat_backend/3rdparty/symfony/console/Application.php","line":171,"function":"doRun","class":"Symfony\\Component\\Console\\Application","type":"->"},{"file":"/home/runner/work/context_chat_backend/context_chat_backend/lib/private/Console/Application.php","line":183,"function":"run","class":"Symfony\\Component\\Console\\Application","type":"->"},{"file":"/home/runner/work/context_chat_backend/context_chat_backend/console.php","line":87,"function":"run","class":"OC\\Console\\Application","type":"->"},{"file":"/home/runner/work/context_chat_backend/context_chat_backend/occ","line":11,"args":["/home/runner/work/context_chat_backend/context_chat_backend/console.php"],"function":"require_once"}],"File":"/home/runner/work/context_chat_backend/context_chat_backend/lib/private/TaskProcessing/Db/Task.php","Line":113,"message":"Error while running background job OC\\TaskProcessing\\SynchronousBackgroundJob (id: 35, arguments: null)","exception":{},"CustomMessage":"Error while running background job OC\\TaskProcessing\\SynchronousBackgroundJob (id: 35, arguments: null)"}}

@marcelklehr
Copy link
Member Author

Integration test will be fixed by nextcloud/server#46779

@marcelklehr marcelklehr enabled auto-merge (squash) July 27, 2024 15:05
@marcelklehr marcelklehr force-pushed the feat/taskprocessing-llm branch from 7c7ea47 to 8e23119 Compare July 29, 2024 07:40
marcelklehr and others added 4 commits July 29, 2024 10:22
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
for more information, see https://pre-commit.ci

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
pre-commit-ci bot and others added 8 commits July 29, 2024 10:22
for more information, see https://pre-commit.ci

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr force-pushed the feat/taskprocessing-llm branch from 8e23119 to 3882270 Compare July 29, 2024 08:22
@marcelklehr marcelklehr merged commit ba7fcfc into master Jul 29, 2024
3 checks passed
@kyteinsky kyteinsky deleted the feat/taskprocessing-llm branch July 30, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants